chore(memory): G1+G4 fixed, BLK-046, LRN-274, contract and plan, journal
This commit is contained in:
1 parent
6cdc374db8
commit
9b7f44aed7
6 files changed
+127
No files matched your search
@@ -2016,3 +2016,8 @@ Rule: when editing a doctrine file under structure locks, grep the test's lock s
|
||||
- **Pattern**: `gitflow finish` purges transient `docs/superpowers/{specs,plans}` only on feature/bugfix branches (BDR-065, `_gitflow_purge_transient`). /ship-feature on a `chore/*` branch (cleanup, no new behavior per gitflow doctrine) → write the plan to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (durable, allowlisted), else transient plan lands on develop.
|
||||
- **Context**: 2026-11-09 connector-deny cleanup via /ship-feature: writing-plans default path docs/superpowers/plans; caught by the transient-artifacts path rule before commit, plan moved.
|
||||
- **Future use**: ship-feature STEP 4 says `start feature`; when doctrine says chore, also move the plan path. Candidate: ship-feature/writing-plans note.
|
||||
|
||||
## LRN-274 — Pipefail callers: no pipe into grep -q, capture output, awk set difference, return 0 (2026-11-10)
|
||||
- **Context**: `list_on_plugins` r2 draft = brace group piped into while loop, ending on `grep -vxF -f`; `detect_uiux_pro_max` = `list_on_plugins | grep -q`. doctor.sh runs `set -euo pipefail`. Grep selecting nothing exits 1; `grep -q` early exit gives SIGPIPE 141. Under pipefail both leak: detect reads OFF though match found. Challenger ran it: `list rc=1`, `detect rc=1`. Test suites run `set -u` only, so tests stayed green.
|
||||
- **Pattern**: lib function sourced by a pipefail caller: capture output into var, test with here-string (`grep -q x <<<"$(fn)"`); set difference in awk not `grep -v -f` (empty pattern file also non-portable); assignment fallbacks `|| var=""`; explicit `return 0` on printing functions.
|
||||
- **Future application**: any lib/*.sh sourced by doctor.sh or another `set -euo pipefail` script; add one test case run inside a `set -euo pipefail` subshell.
|
||||
Reference in new issue
Block a user