chore(memory): G1+G4 fixed, BLK-046, LRN-274, contract and plan, journal
This commit is contained in:
1 parent
6cdc374db8
commit
9b7f44aed7
6 files changed
+127
No files matched your search
@@ -391,3 +391,9 @@ rules:
|
||||
- **Real cause**: stub pattern (LRN-263) copied inline, fail-open: failed write (no `set -e`) or noexec TMPDIR (`command -v` skips non-exec) → real CLI; relative work dir passes same-cwd check, breaks after hook's `cd`.
|
||||
- **Solution**: shared `lib/tests/claude-stub.sh`: `stub_first_or_die` (command -v == stub else exit 1), `claude_stub_install` (absolute dir via `cd -P`, every step `|| exit 1`, control from `/`, `GIT_CEILING_DIRECTORIES`), `claude_stub_calls`; 6 suites adopt, each ends zero-call check; `lib/tests/claude-stub.test.sh` proves fail-closed (no-op chmod script + sentinel fake claude). Commits dc5f127, 7ca6b18 on bugfix/safety-residuals.
|
||||
- **Status**: resolved dc5f127
|
||||
|
||||
## BLK-046 — Banner plugin rows showed user-scope state, not effective profile [resolved 556d0e6] (2026-11-10)
|
||||
- **Date**: 2026-11-10
|
||||
- **Friction**: session banner plugin rows showed user-scope state, not project's. dev project showed `ui-ux-pro-max` in `🟢 ON`; audit project hid `pr-review-toolkit`; /status read `~/.claude/plugins/cache` as active.
|
||||
- **Real cause**: `detect_uiux_pro_max` tested plugin cache only (installed = on); ✅ row grepped `"<id>": true` in user `~/.claude/settings.json`. PROFILE_PLAIN (`profile.sh current --plain`) already held effective state, unused there. Found by code-clean 2026-11-09 (G1, G4).
|
||||
- **Solution**: `list_on_plugins` in lib/detect-plugins.sh: profile `plugin:<id>=on` for managed ids, user-scope true for rest, awk set difference, `return 0`. ✅ row + detect_uiux_pro_max (cache AND enabled) + status-reporter read it; plugin-advisor INPUT names PROFILE. Test lib/tests/session-banner.test.sh SB1-SB8. Commit 556d0e6.
|
||||
@@ -712,3 +712,6 @@ rules:
|
||||
- 2026-11-09: /ship-feature connector-deny-cleanup (chore): dead higgsfield deniedMcpServers + census rule + prose citers removed, 12 files, T13 deny-set test; challenge 3x SOLID, verifier ECARTS x2 (revert hint) -> CONFORME, security PASS x3, opus review fixes. BDR-134 amended, LRN-272/273. Merge on signal.
|
||||
- 2026-11-09: /code-clean BDR-125 obsolescence pass: phases 0/1/2 clean, 4a-4d code clean, 5 all declared artifacts gone; 2 dead sources + 5 stale comments fixed; challenge FATAL x3 on r1 (A2 bench importer, B9 unique security rules, prompt edits = behavior) -> r2; bugs G1-G5 logged, D1-D6 queued in TODO.
|
||||
- 2026-11-09: /hotfix G3 digest journal: _digest_journal awk skips <!-- --> blocks (opener anchored line start, END guard), SD18 3 checks; challenge MAJOR x2 (unanchored opener) folded; template untouched; security PASS.
|
||||
|
||||
## 2026-11-10
|
||||
- 2026-11-10: /bugfix G1+G4 banner effective profile: list_on_plugins (profile managed ids, user scope rest) feeds ✅ row, detect_uiux_pro_max, /status; 2 challenge rounds (doctor pipefail BLOCKER r2), gates MET/CONFORME/PASS; 556d0e6, changelog 6cdc374.
|
||||
@@ -2016,3 +2016,8 @@ Rule: when editing a doctrine file under structure locks, grep the test's lock s
|
||||
- **Pattern**: `gitflow finish` purges transient `docs/superpowers/{specs,plans}` only on feature/bugfix branches (BDR-065, `_gitflow_purge_transient`). /ship-feature on a `chore/*` branch (cleanup, no new behavior per gitflow doctrine) → write the plan to `.claude/tasks/plans/<date>-<slug>-<HHMM>.md` (durable, allowlisted), else transient plan lands on develop.
|
||||
- **Context**: 2026-11-09 connector-deny cleanup via /ship-feature: writing-plans default path docs/superpowers/plans; caught by the transient-artifacts path rule before commit, plan moved.
|
||||
- **Future use**: ship-feature STEP 4 says `start feature`; when doctrine says chore, also move the plan path. Candidate: ship-feature/writing-plans note.
|
||||
|
||||
## LRN-274 — Pipefail callers: no pipe into grep -q, capture output, awk set difference, return 0 (2026-11-10)
|
||||
- **Context**: `list_on_plugins` r2 draft = brace group piped into while loop, ending on `grep -vxF -f`; `detect_uiux_pro_max` = `list_on_plugins | grep -q`. doctor.sh runs `set -euo pipefail`. Grep selecting nothing exits 1; `grep -q` early exit gives SIGPIPE 141. Under pipefail both leak: detect reads OFF though match found. Challenger ran it: `list rc=1`, `detect rc=1`. Test suites run `set -u` only, so tests stayed green.
|
||||
- **Pattern**: lib function sourced by a pipefail caller: capture output into var, test with here-string (`grep -q x <<<"$(fn)"`); set difference in awk not `grep -v -f` (empty pattern file also non-portable); assignment fallbacks `|| var=""`; explicit `return 0` on printing functions.
|
||||
- **Future application**: any lib/*.sh sourced by doctor.sh or another `set -euo pipefail` script; add one test case run inside a `set -euo pipefail` subshell.
|
||||
Reference in new issue
Block a user