From 794e7206580160acf1f9fcee78e35d8a2d3c176b Mon Sep 17 00:00:00 2001 From: bchanot Date: Sun, 18 Oct 2026 19:04:14 +0200 Subject: [PATCH] chore(memory): guardrails fix loop, TODO T10-T14, journal --- .claude/memory/journal.md | 1 + .claude/tasks/TODO.md | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index e99c90a..1d4521a 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -625,3 +625,4 @@ rules: - Guardrails ask (user): 5 domains baseline + API/access hygiene + test skill. `rules/secure-by-default.md` always-on (CLAUDE.global 320/320, BDR-085 path). `/guardrails` = stdlib py scanner (6 domains, FAIL/WARN/MANUAL) + judgment; auditor gate runs api+supabase. Calibrated on game/faunosteo: 7 FP classes fixed (stopPropagation wrappers, hidden inputs, service_role-only policies, border focus, UI routes dir, ignored .env, dup origin). Branch feature/secure-by-default, not committed. BDR-120 pending user approval. - Passwords added on user question ("stockés en clair ?"): gap, rule had none. `checks/passwords.py` (api domain): clear column w/o hash lib, `==` or SQL compare, fast hash, log call, literal. Calibrated 7 projects: zero noise after htpasswd volume-mount FP. Suite 89/89, `make test` green. - Live probe added (user: "est-ce qu'il attaque de l'exterieur ?"). `probe.py` read-only, `--authorized`, env secrets, same-host redirect only, budget-capped. 5 probes confirm a hole from outside (OPEN/CLOSED). Suite 16/16 on a localhost fixture. Classifier blocked edits/tests carrying exploit-language and the SSRF-shaped redirect fixture; full-file Write passed, so probe strings are neutral and interpretation lives in checks.md. +- Fix loop added (user: propose fixes via Fable, user accepts, re-pass proves). Reused bugfix circuit: contract criteria with scanner oracle (`--assert-absent`, GUARDRAILS-CLEAR) run by gates.sh, bugfixer executor, verify-secure gates, re-pass `--baseline` (GUARDRAILS-NO-NEW), 2 rounds max. Proposals on route plan (best tier = fable first). Model gate added, census locks updated. diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index e0f7bf9..f8ccb5f 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -12,6 +12,12 @@ Language call: scanner is Python stdlib, not Rust (default-language contraindica - [x] T7 `make test` all green (70 guardrails checks), shellcheck clean, 25/80/5/5 limits met; calibrated on 8 real projects (game, faunosteo, zenquality, robin_petier, alphalink, game-deploy, config, explanations), 9 false-positive classes fixed and locked by benign tests. Journal done. [ ] BDR-120 awaits user approval; [ ] commit + merge = user go - [x] T8 passwords (user ask 2026-10-18): doctrine bullet in the rule (argon2id, no clear compare, no log, no literal, delegated auth), `checks/passwords.py` in the api domain (API-PASSWORD-PLAINTEXT / WEAK-HASH / LOGGED FAIL, LITERAL WARN), 8 mutants + 10 benign locks (89 checks), auditor maps PLAINTEXT to CRITICAL; calibrated on 7 projects: 0 hits after one FP fix (yaml volume mount `htpasswd:/etc/...`) - [x] T9 live probe (user ask 2026-10-18, "attaque de l'exterieur ?"): `skills/guardrails/scripts/probe.py` read-only (GET/HEAD/OPTIONS, `--authorized` gate, env secrets, same-host redirect only, request budget, 25-req burst cap). 5 probes: anon-read, cross-user, no-auth route, cors-reflect, rate-limit. Suite `lib/tests/guardrails-probe.test.sh` 16/16 vs a localhost http.server fixture. SKILL STEP 5 + checks.md section + CHANGELOG/README/USAGE. Redirect-guard unit test blocked by the auto-mode classifier (SSRF-shaped fixture), guard is code-reviewed. +- Fix loop (user ask 2026-10-18): audit -> fix proposals (Fable via route plan) -> user accepts -> fixes applied -> re-pass proves all fixed. Reuse /bugfix circuit: contract with scanner oracles, bugfixer executor, lib/verify-secure-loop.md gates. +- [x] T10 scan.py `--assert-absent RULE:path,...` (contract oracle: exit + marker reflect only the listed pairs, positive control = domain applies + files>0) and `--baseline ` (re-pass: fixed / remaining / new); tests incl. positive control +- [x] T11 SKILL.md: model gate, STEP propose (grouped per rule+path, visible choices named, MANUAL = user steps), STEP approve (prose gate), STEP fix (gitflow aiguillage, contract + oracles, bugfixer, verify-secure-loop), STEP re-pass (baseline diff + probe re-run on go, max 2 rounds), commit gate +- [x] T12 citers: verify-secure-loop header, contract-interview flow list, bugfixer description, model-routing census adds guardrails +- [x] T13 docs: checks.md oracle section, CHANGELOG, README, USAGE, test-prompts +- [x] T14 make test green (scan suite 106: check modes + gates.sh UNMET->MET), oracle calibrated read-only on game: real hit -> PRESENT rc1, self-baseline -> NO-NEW rc0 ## 2026-10-17 — /explain-diff skill: HTML explanation of a diff (feature/explain-diff) Source: geoffreylitt gist `explain-diff-html` (Notion variant dropped). Built through the skill-creator loop (draft, evals with/without skill, user review).