chore(memory): dead-deny lock done, BDR-145, LRN-280, hand edit queued

This commit is contained in:
bchanot committed 2026-11-12 14:30:29 +01:00
1 parent 79f1a3fc2c
commit 72ae6084da
6 files changed
+168 -1

No files matched your search

+2 -1
View File
@@ -89,7 +89,8 @@ Shared rules for every phase:
- [x] **Phase 2, guards** (shipped 2026-11-02 on feature/phase2-guards, merge on user signal: bench `.claude/tasks/plans/2026-11-02-phase2-bench/` (16 ask, 7 deny approved; quoted finish rule, `gitflow_finish*`, `bash -s*` not approved), rtk rc 3 passthrough 60ee4a9, router write guard with a session skill latch 22ff57b + 9bbd1d5, code-limits hook f21e265, locks T62/T63 9887c14, settings 6899a72, release finish in the main loop 536d39e, doctrine 0bf4620, CHANGELOG c3a6977; contract `.claude/tasks/contracts/2026-11-02-phase2-guards-1545.md`) (redesigned 2026-10-25 after a 3-lens challenge, re-challenged the same day: native ask gate, guard hosted in model-router, interpreters in prose, commit-msg hook deferred)
- [ ] Phase 2 residuals (stated 2026-11-02): Bash write forms are outside the routing guard (the harness auto-mode "prefer Bash" path); a register.ts reload resets the skill latch; `.claude/worktrees/` writes are code; code-limits state dirs stay in TMPDIR; not caught by a static rule: `… | bash -s`, a sourced `gitflow_finish`, `git -C <dir> merge` (soft_deny prose only).
- [ ] Phase 2 security gate follow-ups (2026-11-02, non-blocking): MEDIUM `rtk read -n .env` / `rtk read a.txt .env` typed directly pass every static deny (rc 3 → passthrough, no rule) → bench `Bash(rtk read * .env*)`, `Bash(rtk read * */.env*)` + `*/rtk` twins and teach phase2.jq the `* <path>` shape; LOW code-limits state dir (`mkdir -m 700`, owner check); LOW awk evasions (`system (`, `awk -f`, `gawk`/`mawk`); LOW pre-existing `cat x.key` (no dir prefix) parity gap; doctor.sh:255 jq message should name code-limits and push-guard. MEDIUM rtk read part done 2026-11-06 97c6afc (2 rules, bench R3-R7, LRN-266); the LOWs stay open.
- [ ] User hand edit (phase 2 hand-over): remove the 6 dead deny entries (`Bash(docker run * -v /:*)`, `Bash(git push * :*)`, `Write(**/.git/config)`, `Write(**/.gitconfig)`, `Write(~/.gitconfig)`, `Write(~/.config/git/config)`) and, if wanted, the 6 obsolete `rtk cat|head|tail` forms; lib/tests/push-guard.test.sh T41 (the 4 Write lines) and T42 (base = last release) must be edited alongside.
- [ ] User hand edit (phase 2 hand-over): remove EXACTLY the 6 dead deny entries from settings.json (`Bash(docker run * -v /:*)`, `Bash(git push * :*)`, `Write(**/.git/config)`, `Write(**/.gitconfig)`, `Write(~/.gitconfig)`, `Write(~/.config/git/config)`), nothing else; lib/tests/push-guard.test.sh is prepared by feature/dead-deny-lock (T41 drops the 4 Write lines, T42 forgives only the 2 Bash lines that main carries). Any other removal turns T42 red by design. With that edit, CHANGELOG [Unreleased]: amend :51 gitflow deny bullet ("18 entries" → 14, "Edit/Write of" → "Edit of"; the Write twins never shipped) and add one Fixed bullet (2.0.0 forms `docker run * -v /:*` / `git push * :*` never matched, working forms added ac23cc6, dead ones dropped); :18 "(98 checks)" stale, drop or refresh from a real run.
- [ ] rtk deny forms (user 2026-11-12, split from the line above): the 6 `rtk cat|head|tail *.env*` deny forms (`Bash(rtk cat *.env*)`, `Bash(*/rtk cat *.env*)`, head, tail) said obsolete; removing them needs a verified reason per form and reviewed rows in the push-guard T42 justified list, as its own run.
- Killed by the challenges: the phrase-list merge gate; the `$.ui.ask` mod gate (its BDR-068 exception detector was never true: finish runs in the user's reply turn; a hard_deny naming mod sources was the robustness BLOCKER); G2 destructive guard (BLK-022, stays a user-driven task); whole-file code-limit reports (1498 lines > 80 cols across 92 files, over-fires); parsing commit text from Bash; Bash write-form detection in the routing guard (no measured Bash evasion, every inline write was Edit/Write).
- Merge gate = native `ask` rules in settings.json, no mod (user pick 2026-10-25; bench r3 G1-G7: all forms DENIED headless incl. `"$HOME"`, absolute path, after `source`; `start` RAN): `Bash(bash */gitflow.sh finish*)`, `Bash(gitflow_finish*)`, `Bash(git merge *)`; evaluate in the same bench `Bash(git pull *)` and `git push x:develop` forms before adding them. Trade-off accepted: the BDR-068 /close auto-finish gets one dialog click (ask beats allow, no exemption); release-executor finish prompts too (its dispatcher runs finish inline if a sub-agent cannot prompt, BLK-018 option b). hard_deny line: "never edit `permissions.ask` to skip the gate".
- Routing guard (user pick: "always through a skill") hosted in `mods/model-router` (owner of the only run signal; mod state is plugin-private, `runMain` is BEST-tier-only and never ends: wrong signal). `tool.call` on Edit/Write/NotebookEdit of a code file by the MAIN loop (no `agentId`) → deny with reason "route through /hotfix (≤2 files, obvious), /feat, /bugfix or /ship-feature" UNLESS this turn's `turnMain.source ∈ {skill, model}` or a `/route` sticky is in force (explicit escape hatch). Free: docs (.md), `.claude/**`, sub-agents, any write inside a skill run. Bash write forms deferred until a measured evasion. hard_deny gains "a guard redirect is not a refusal to route around: enter the skill". Doctrine: the ceiling bullet becomes "the main loop writes no code outside a skill run, whatever the model". Proof: routing bench cases (L3 must enter a skill), long-brief replay in a clone, false-deny fixtures (doc edits, executor edits, in-skill edits), guard-off = today.