From 7052c6858e50398566faccf76942ad3711dee907 Mon Sep 17 00:00:00 2001 From: bchanot Date: Wed, 28 Oct 2026 17:26:04 +0100 Subject: [PATCH] =?UTF-8?q?chore(memory):=20EVAL-005/028/040=20Index=20act?= =?UTF-8?q?ions=20materialized;=20contract=20clarifications=20=E2=80=94=20?= =?UTF-8?q?memory=20v2=20verifier=20gap?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .claude/memory/evals.md | 3 +++ .claude/tasks/contracts/2026-10-27-memory-v2-write-2030.md | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.claude/memory/evals.md b/.claude/memory/evals.md index b291e46..a8ece0a 100644 --- a/.claude/memory/evals.md +++ b/.claude/memory/evals.md @@ -66,6 +66,7 @@ rules: - **Method / why missed**: I treated the pre-existing `CLAUDE_LINES` as established and only touched the lines I was adding/removing. Spotting the redundancy needs cross-referencing TWO config layers (shell alias vs settings.json) — a semantic check I never ran. Masked further: the user's `.bashrc` is hand-managed and the alias line wasn't even present, so it looked inert. - **Anomaly**: not just dead config — a CLI flag (`--effort max`) silently OVERRIDES the settings.json value (`xhigh`). Real correctness bug. - **Action**: when editing installer shell-config, audit EACH existing line against the current settings.json / CLAUDE.md source of truth, not only the lines being changed. Removed the alias + added cleanup. General rule: reconcile config to ONE source of truth across env/alias/settings layers. +- **Status (2026-10-28)**: correct (Index Action, upgrade) --- @@ -246,6 +247,7 @@ Dogfood: 3 blind lenses attacked the v1 plan for the plan-challenge feature itse - **Method**: paired same-judge 3-majority per round (v2.1); judges live-exec where artifact executable (5 units: skills-perso, profile, plugin-pair, status-reporter, gitflow). Absolute scores triage-only. Totals main-thread (LRN-018 applied). - **Anomalies**: (1) 0 reverts/ties in 60 verdicts — homogeneous-better checked: skeptic lens found real residuals 3x (doctor.sh cost source, hotfix RULES leftover restore, FILE(S) new-marker) → judges engaged. (2) census lock RED on line-rewrap, make test caught → LRN-144. (3) head-pipe masked grep exit 2x → LRN-143. - **Action**: v2.1 paired = standard. Post-run absolute rescore skipped by design (would be judge-noise theater). +- **Status (2026-10-28)**: keep (Index Action, upgrade) --- @@ -335,6 +337,7 @@ Dogfood: 3 blind lenses attacked the v1 plan for the plan-challenge feature itse - **Method**: 3 blind opus challengers (simplicity CONCERNS(3), robustness CONCERNS(6), correctness FATAL(8)) + 1 confirmation (CONCERNS(4)); every BLOCKER/MAJOR closed by a named plan change (r2, r3); then feater, GATE 0, verifier, security. - **Anomaly**: r1 carried 2 BLOCKER (explicit Agent `model` overridden at every step; Skill bridge answer shape refused by the output schema → doublon kept) + 10 MAJOR, all invisible to me: spike levers carried over as design (`agentsNext`, per-step model rewrite), a table copying 21 pins = third source of truth, writes on main from sub-agent loops. Confirmation found 4 more MAJOR (explicit params vs in-agent writes, `e.wait`, vacuous test assertions, haiku effort). Executor then DONE first pass, verifier CONFORME 6/6, security PASS: the plan was the whole risk. - **Action**: a mod plan always goes through the full round + confirmation; test assertions must read the one line that carries the value; spike code is a FACT source, never a design source ([[BDR-115]], [[LRN-205]], [[LRN-206]]). +- **Status (2026-10-28)**: keep the round, never dispatch a mod plan without it (Index Action, upgrade) ## EVAL-041 — model-router W1-C: the plan was the whole risk, two confirmations were needed - **Date**: 2026-10-09 diff --git a/.claude/tasks/contracts/2026-10-27-memory-v2-write-2030.md b/.claude/tasks/contracts/2026-10-27-memory-v2-write-2030.md index 33b0d10..3d4220b 100644 --- a/.claude/tasks/contracts/2026-10-27-memory-v2-write-2030.md +++ b/.claude/tasks/contracts/2026-10-27-memory-v2-write-2030.md @@ -10,6 +10,9 @@ Phase 4a of the context mod queue (BDR-125), TODO.md "Phase 4a, memory v2 write ## CLARIFICATIONS (pass A: scope gaps surfaced by the read-before, settled at the STEP 1 brainstorm — see [gated] rows below) +Q: files outside the seed FILE SCOPE that the approved plan (STEP 3 gate 2026-10-28, plan r3 Tasks 2/3/5/6) requires? / A: agents/analyzer.md (Task 5 citer), lib/tests/run-deterministic.sh (Task 3 chokepoint test), skills/reconcile/SKILL.md (Task 2 parser doc + test count), skills/prune-memory/tests/fixtures/red6-check/ added and red6-orphan/ deleted (Task 6: RED-6 asserted "no false ORPHAN INDEX", a check that only exists with an Index; § D removal makes it obsolete, red6-check replaces it as the flip test) [gated 2026-10-28, plan approval] +Q: EVAL Index "Action" column at upgrade? / A: the 2026-10-27 gate dropped the column on the premise the body carries **Action**; where the body has no status word, the Index action is materialized as a body status line (verifier gap 2026-10-28, EVAL-005/028/040) [gated 2026-10-27, refined 2026-10-28] + ## ACCEPTANCE CRITERIA 1. `lib/memory.sh [-C dir] add --title --body-file [--status ] [--supersedes ]` appends one entry `## -NNN — [<status>] (<date>)` + body at the end of the registry, NNN = max heading ID + 1, under a lock; prints the new ID on stdout; rc 2 with a named reason on a bad kind, a missing body file, a duplicate ID after allocation, or a validator failure (nothing written). 2. `memory.sh status <ID> <new>` appends a dated status line to that entry (inserted before the next heading, after the body), never rewrites an existing line; rc 2 when the ID does not exist. @@ -25,7 +28,7 @@ Phase 4a of the context mod queue (BDR-125), TODO.md "Phase 4a, memory v2 write 12. Proof: writer round-trip test, concurrent-add race test (two adds, distinct IDs), status parser on BLK-032..034 fixtures, every other project's `.claude/memory/` untouched (no diff outside this repo), `make test` all green, shellcheck clean, every new lib line ≤ 80 chars, functions ≤ 25 logic lines / ≤ 5 locals / ≤ 5 params. CHECK: make test 2>&1 | tail -1 EXPECT: all suites green - EVIDENCE: PENDING + EVIDENCE: MET exit=0 marker-found :: all suites green 13. [gated 2026-10-28] `memory.sh upgrade` migrates every measured v1 dialect (hyphen, pipe, `###` headings, title-suffix status, `date: · status:`, `**Statut** :`, no frontmatter) to v2: headings normalized to `## ID — title (date)`, frontmatter added, open/closed verdict of every entry identical before and after (oracle), idempotent; proven on copies of the 13 other projects. Applying it to those repos is a later per-repo pass, not this branch.