From 60031c1bef877c6baf4258ed4efbaebcc59ddf9c Mon Sep 17 00:00:00 2001 From: Bastien Chanot Date: Sun, 21 Jun 2026 11:59:37 +0200 Subject: [PATCH] chore(design-gate): repoint agents + test to profile remedy MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The gate's remedy is now /profile design (not an atomic ui-ux-pro-max toggle), but several callers still described the old "ask user to activate ui-ux-pro-max" behavior. Repoint the prose — the `Follow lib/design-gate.md` pointers stayed valid (the gate was extended in place), so only descriptions change: - agents/feater.md, hotfixer.md, bugfixer.md (STEP 0.5/1.5 gate bullet): signals found → run design-tool-gate.sh; if INCOMPLETE → /profile design. - agents/feater.md rule 6: trigger is "design toolchain incomplete", not "ui-ux-pro-max inactive". - agents/plugin-advisor.md: gate points at /profile design when the toolchain is incomplete. - skills/feat/test-prompts.json (id 2): expected behavior updated; still valid JSON. No logic change — descriptions only, aligned with the profile-based gate. Co-Authored-By: Claude Opus 4.8 (1M context) --- agents/bugfixer.md | 3 ++- agents/feater.md | 5 +++-- agents/hotfixer.md | 3 ++- agents/plugin-advisor.md | 2 +- skills/feat/test-prompts.json | 2 +- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/agents/bugfixer.md b/agents/bugfixer.md index 6fa9299..7d6d4d5 100644 --- a/agents/bugfixer.md +++ b/agents/bugfixer.md @@ -38,7 +38,8 @@ git log --oneline -20 --all -- Follow `$HOME/.claude/lib/design-gate.md`: - Scan $ARGUMENTS and target files for design/UI/style signals (CSS, component, layout, animation). -- If signals found and `ui-ux-pro-max` inactive → ask user to activate. +- If signals found → run `design-tool-gate.sh`; if it reports INCOMPLETE, + tell the user to run `/profile design` before proceeding. - If no signals → skip (zero overhead). ## STEP 2 — INVESTIGATE diff --git a/agents/feater.md b/agents/feater.md index d03e3f6..43b6131 100644 --- a/agents/feater.md +++ b/agents/feater.md @@ -34,7 +34,7 @@ Read the relevant existing code to understand the context. | 3 | New route family / new top-level module / new DB migration | ESCALATE → `/ship-feature` | | 4 | Estimated diff > 5 files | ESCALATE → `/ship-feature` | | 5 | User wording is uncertain ("not sure how", "what do you think") | ESCALATE → `/ship-feature` (needs brainstorming) | -| 6 | UI feature on a stack with a design system AND `ui-ux-pro-max` inactive | Proceed in `/feat`, but flag it in STEP 0.5 design gate | +| 6 | UI feature on a stack with a design system AND the design toolchain incomplete | Proceed in `/feat`, but flag it in STEP 0.5 design gate | | 7 | Otherwise | PROCEED in `/feat` | ### Worked examples @@ -54,7 +54,8 @@ FEAT: — rule , ~ files, Follow `$HOME/.claude/lib/design-gate.md`: - Scan $ARGUMENTS and target files for design/UI/style signals. -- If signals found and `ui-ux-pro-max` inactive → ask user to activate. +- If signals found → run `design-tool-gate.sh`; if it reports INCOMPLETE, + tell the user to run `/profile design` before proceeding. - If no signals → skip (zero overhead). ## STEP 1 — MINI-PLAN diff --git a/agents/hotfixer.md b/agents/hotfixer.md index 69c816b..e66041b 100644 --- a/agents/hotfixer.md +++ b/agents/hotfixer.md @@ -35,7 +35,8 @@ git log --oneline -3 Follow `$HOME/.claude/lib/design-gate.md`: - Scan $ARGUMENTS and target files for design/UI/style signals (CSS, component, styling, animation). -- If signals found and `ui-ux-pro-max` inactive → ask user to activate. +- If signals found → run `design-tool-gate.sh`; if it reports INCOMPLETE, + tell the user to run `/profile design` before proceeding. - If no signals → skip (zero overhead). ## STEP 2 — PRE-FLIGHT + FIX diff --git a/agents/plugin-advisor.md b/agents/plugin-advisor.md index 1cfb09b..44fe054 100644 --- a/agents/plugin-advisor.md +++ b/agents/plugin-advisor.md @@ -246,7 +246,7 @@ When the plugin-advisor detects a `simple` or `hotfix` signal, suggest the appro **Escalation path:** `/hotfix` → `/bugfix` → `/ship-feature` (bugs), `/feat` → `/ship-feature` (features). Each skill documents when to escalate to the next level. -**Design gate:** `/feat`, `/hotfix`, and `/bugfix` include a lightweight design gate (`lib/design-gate.md`) that auto-detects UI/style signals and asks the user to activate `ui-ux-pro-max` if inactive. This covers the gap where lightweight skills previously had no plugin awareness for design tasks. +**Design gate:** `/feat`, `/hotfix`, and `/bugfix` include a lightweight design gate (`lib/design-gate.md`) that auto-detects UI/style signals and, if the design toolchain is incomplete, points the user at `/profile design`. This covers the gap where lightweight skills previously had no plugin awareness for design tasks. --- diff --git a/skills/feat/test-prompts.json b/skills/feat/test-prompts.json index 323130f..c3f5117 100644 --- a/skills/feat/test-prompts.json +++ b/skills/feat/test-prompts.json @@ -1,5 +1,5 @@ [ {"id": 1, "prompt": "Add a /health endpoint to the API that returns 200 OK with version info", "expected": "Light planning, direct implementation in 1-3 files, no design brainstorm, no plugin check, run build/tests after"}, - {"id": 2, "prompt": "Add dark mode toggle to the settings page", "expected": "Detect UI signal → trigger design gate (offer ui-ux-pro-max if inactive), then implement small feature"}, + {"id": 2, "prompt": "Add dark mode toggle to the settings page", "expected": "Detect UI signal → trigger design gate (run design-tool-gate.sh; if toolchain incomplete, point at /profile design), then implement small feature"}, {"id": 3, "prompt": "Petite feature : afficher un badge 'New' à côté des items créés cette semaine", "expected": "FR trigger, scope check (≤5 files), implement directly, no orchestrator overhead"} ]