From 5a1fff50302d648bd1cb838c0607f0a7663290ff Mon Sep 17 00:00:00 2001 From: Bastien Chanot Date: Sat, 4 Jul 2026 14:19:56 +0200 Subject: [PATCH] =?UTF-8?q?chore(skills):=20drop=20find-skills=20=E2=80=94?= =?UTF-8?q?=20unused,=20and=20its=20update=20step=20began=20timing=20out?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RC fix (soak day 1): `make update` step 7.5 failed on a 300s clone timeout of alchaincyf/find-skills. The skill (search the skills.sh registry from Claude) was never used; the discovery case stays reachable manually via `npx -y skills find `. Removed from install-plugins.sh (install list + summary + comment), update-all.sh (refresh list), link.sh (NPX_EXTERNAL_SKILLS), lib/toggle-external.sh (MANAGED_TOOLS + case arms), plugin-advisor.md, .gitignore; local skills/find-skills symlink deleted. Memory-registry and test-fixture mentions kept — append-only history. toggle-external `list` verified post-removal; suites 8/8. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_01XpphkdTosUzokBDNG7PToS --- .gitignore | 1 - CHANGELOG.md | 3 +++ agents/plugin-advisor.md | 6 +++--- install-plugins.sh | 4 +--- lib/toggle-external.sh | 11 +++++------ link.sh | 2 +- update-all.sh | 1 - 7 files changed, 13 insertions(+), 15 deletions(-) diff --git a/.gitignore b/.gitignore index 1f2bfe5..cd80599 100644 --- a/.gitignore +++ b/.gitignore @@ -68,7 +68,6 @@ skills/impeccable # External skills installed via `npx skills add` — auto-created by link.sh skills/darwin-skill -skills/find-skills # Context7 docs-lookup skill — installed by `ctx7 setup --claude --cli` # (install-plugins.sh Step 6, when absent) into ~/.claude/skills (a symlink to diff --git a/CHANGELOG.md b/CHANGELOG.md index a153cf7..ab1b498 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,9 @@ Format follows [Keep a Changelog](https://keepachangelog.com/). - `gitflow_finish` ignored its ` ` arguments and always merged the checked-out branch — naming a different branch silently merged the wrong one. The arguments are now an optional safety assertion: if given and not equal to the current branch, `finish` refuses with a clear error instead of merging. No-argument calls (the only real caller) are unchanged. - `doctor.sh` false-warnings removed (a check that cries wolf is one you learn to ignore): `cargo` absence no longer claims "RTK unavailable" (RTK ships as a prebuilt binary); `check_symlink` no longer flags files reached through directory-level symlinks (e.g. `hooks/session-start.sh`); the GStack check counts the per-skill symlinks instead of a `skills/gstack` link that `link.sh` deliberately removes; the token-budget estimate is measured against the ~200k context window instead of a mis-framed "~11k session budget" that produced a false "92% CRITICAL". +### Removed +- **find-skills** (alchaincyf) — skill-discovery helper dropped from the toolchain (install/update/link/toggle/advisor). Never used, and its `make update` refresh step had started failing on clone timeouts. The discovery use case stays reachable manually: `npx -y skills find `. + ## [4.0.0] — 2026-06-30 ### Added diff --git a/agents/plugin-advisor.md b/agents/plugin-advisor.md index 701aa0b..35998a6 100644 --- a/agents/plugin-advisor.md +++ b/agents/plugin-advisor.md @@ -19,7 +19,7 @@ Detect active plugins and project signals. Recommend enable/disable. Apply compa claude plugin list 2>/dev/null || echo "plugin-list-unavailable" # External (non-marketplace) tools status — gstack, emil-design-eng, -# darwin-skill, find-skills. Managed by lib/toggle-external.sh since +# darwin-skill. Managed by lib/toggle-external.sh since # `claude plugin enable|disable` does not apply to them. bash "$HOME/.claude/lib/toggle-external.sh" list 2>/dev/null || echo "toggle-external-unavailable" @@ -353,8 +353,8 @@ RULE: IF `complex-arch` signal (multiple services, event bus, distributed system ## TOGGLING EXTERNAL TOOLS Marketplace plugins toggle via `claude plugin enable|disable @`. -Non-marketplace tools (gstack per-skill symlinks, emil-design-eng, darwin-skill, -find-skills) toggle via `bash $HOME/.claude/lib/toggle-external.sh enable|disable `. +Non-marketplace tools (gstack per-skill symlinks, emil-design-eng, darwin-skill) +toggle via `bash $HOME/.claude/lib/toggle-external.sh enable|disable `. When a recommendation flips the state of one of those tools, emit the exact command — never write files directly. diff --git a/install-plugins.sh b/install-plugins.sh index 4f501ab..d492991 100644 --- a/install-plugins.sh +++ b/install-plugins.sh @@ -832,7 +832,6 @@ echo "" NPX_SKILLS=( "alchaincyf/darwin-skill" - "alchaincyf/find-skills" ) # `skills add` resolves its target (.agents/skills/, skills-lock.json) RELATIVE @@ -985,7 +984,7 @@ echo "" # STEP 10 — REFRESH SYMLINKS (final, so this script is self-sufficient) # ============================================================ # Steps 2/8/8.5 INSTALL skills (gstack submodule, emil/frontend/motion, npx -# darwin/find-skills) that link.sh must symlink into ~/.claude/skills/. Since +# darwin-skill) that link.sh must symlink into ~/.claude/skills/. Since # link.sh runs BEFORE this script in install.sh, those symlinks would be missing # on a fresh run until link.sh is run again by hand. Re-run it here so # `make plugin` (and `make install`) finish complete — nothing left to do. @@ -1023,7 +1022,6 @@ echo " 🔄 frontend-design — distinctive frontend interfaces, anti-AI- echo " 🔄 impeccable — /impeccable design verbs + 45-rule deterministic detector (npx impeccable detect)" echo " 🔄 design-motion-principles — motion/animation design, 3-designer lens (kylezantos)" echo " 🔄 darwin-skill — autonomous skill optimizer (npx skills, ~/.agents/skills/)" -echo " 🔄 find-skills — skill discovery helper (npx skills, ~/.agents/skills/)" echo " 🔄 magic MCP — 21st-dev UI generation MCP (toggle: lib/toggle-external.sh enable magic)" echo "" echo " All plugins installed at: user scope (~/.claude/plugins/)" diff --git a/lib/toggle-external.sh b/lib/toggle-external.sh index ca76e63..c291439 100755 --- a/lib/toggle-external.sh +++ b/lib/toggle-external.sh @@ -20,7 +20,6 @@ # gstack — per-skill symlinks populated by gstack's own setup # emil-design-eng — single symlink → skills-external/emil-design-eng # darwin-skill — single symlink → ~/.agents/skills/darwin-skill -# find-skills — single symlink → ~/.agents/skills/find-skills # magic — 21st-dev Magic MCP server (API key in .env) # # For fine-grained activation (only design skills, only qa skills, only @@ -41,7 +40,7 @@ warn() { echo -e "${YELLOW}⚠${NC} $1"; } err() { echo -e "${RED}✗${NC} $1"; } # All non-plugin tools this script can toggle. -MANAGED_TOOLS=(gstack emil-design-eng darwin-skill find-skills magic) +MANAGED_TOOLS=(gstack emil-design-eng darwin-skill magic) # Load MAGIC_API_KEY (and any other secrets) from $REPO/.env if present. # Called only by the magic branch — other tools don't need env vars. @@ -81,7 +80,7 @@ status_tool() { [ -d "$REPO/skills-external/emil-design-eng" ] || { echo "missing"; return; } [ -e "$SKILLS_DIR/emil-design-eng" ] && echo "enabled" || echo "disabled" ;; - darwin-skill|find-skills) + darwin-skill) [ -d "$HOME/.agents/skills/$tool" ] || { echo "missing"; return; } [ -e "$SKILLS_DIR/$tool" ] && echo "enabled" || echo "disabled" ;; @@ -116,7 +115,7 @@ disable_tool() { done < <(gstack_skills) ok "gstack disabled ($moved symlinks moved)" ;; - emil-design-eng|darwin-skill|find-skills) + emil-design-eng|darwin-skill) if [ -e "$SKILLS_DIR/$tool" ]; then rm -rf "${DISABLED_DIR:?}/${tool:?}" mv "$SKILLS_DIR/$tool" "$DISABLED_DIR/$tool" @@ -158,11 +157,11 @@ enable_tool() { ok "gstack enabled ($moved symlinks restored)" fi ;; - emil-design-eng|darwin-skill|find-skills) + emil-design-eng|darwin-skill) local src case "$tool" in emil-design-eng) src="$REPO/skills-external/$tool" ;; - darwin-skill|find-skills) src="$HOME/.agents/skills/$tool" ;; + darwin-skill) src="$HOME/.agents/skills/$tool" ;; esac if [ -e "$DISABLED_DIR/$tool" ]; then rm -rf "${SKILLS_DIR:?}/${tool:?}" diff --git a/link.sh b/link.sh index f46590b..d7ffc99 100644 --- a/link.sh +++ b/link.sh @@ -90,7 +90,7 @@ done # absolute paths so the link stays valid regardless of where the # repo is cloned (relative ../../ paths broke on repos deeper than # one level below $HOME). -NPX_EXTERNAL_SKILLS=(darwin-skill find-skills) +NPX_EXTERNAL_SKILLS=(darwin-skill) for _ext in "${NPX_EXTERNAL_SKILLS[@]}"; do _target="$HOME/.agents/skills/$_ext" _link="$REPO/skills/$_ext" diff --git a/update-all.sh b/update-all.sh index 2a0b5d2..ba40d72 100644 --- a/update-all.sh +++ b/update-all.sh @@ -388,7 +388,6 @@ echo "── Updating external skills (npx skills)..." if command -v npx &>/dev/null; then NPX_SKILLS=( "alchaincyf/darwin-skill" - "alchaincyf/find-skills" ) for _src in "${NPX_SKILLS[@]}"; do _name="${_src##*/}"