From 482fd378081a019957e4d5ffec600916dd99063d Mon Sep 17 00:00:00 2001 From: bchanot Date: Wed, 18 Nov 2026 10:43:54 +0100 Subject: [PATCH] chore(memory): LRN-299 cursor parser guards the sink --- .claude/memory/learnings.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.claude/memory/learnings.md b/.claude/memory/learnings.md index 3da5e8a..2f3d23b 100644 --- a/.claude/memory/learnings.md +++ b/.claude/memory/learnings.md @@ -2152,3 +2152,8 @@ Rule: when editing a doctrine file under structure locks, grep the test's lock s - **Context**: 2026-11-17 run B2: scratch-clone simulation 15/15 MET, yet challengers found end call after FEAT COMPLETE (done already printed), tour runners (sub-agents) execute STEP 3 holding main-loop call, skip "fixed or committed anything" always true (tour commits report each run). Fixed in plan r2/r3 before dispatch. - **Apply**: anchor position oracles on flow's done/merge moment (summary or finish line), not nearby heading; per site list executor (main loop vs runner/sub-agent) and falsifiable condition. Non-idempotent applier fix after commit: delta group from HEAD + byte-compare with fresh apply from base (review1 == fresh). - **Reference**: docs plan 2026-11-17-advisor-points-b2 (purged at finish, git keeps), LRN-296, LRN-284 + +## LRN-299 — Cursor parser: refuse the overwrite at the sink, not the label shapes at the source (2026-11-18) +**Context**: gates.sh hotfix c25a7ea (2026-11-17). LRN-284 named `1b.` label: parser drops it as prose, cursor `_CUR` still on previous criterion, stray CHECK/EXPECT overwrite its oracle → false MET. First plan: reject `^[0-9]` non-`N. text` lines. Advisor + scratch fixtures: indented ` 2.`, `- `, `**2.**` labels gave same false MET. +**Pattern**: line parser with current-record cursor → close overwrite at sink: refuse second write of already-set field (`_set_attr` guard), not enumerate bad label shapes at source. Source-side rule only names the common shape (better error message). +**Apply**: any cursor parser (contract ledger, registry, config sections). Before fixing a reported bad input shape, fixture sibling shapes (indent, bullet, bold) against the same sink; scan existing data for repeated fields first so guard changes no past verdict.