feat(prune-memory): step D, gate feedback noisy rewrite and BDR-100 promotion

Reads FEEDBACK.md for this repo's tag; RED-10 runs the real block.
This commit is contained in:
bchanot committed 2026-11-12 20:30:46 +01:00
1 parent 7e87d7722d
commit 39f979068a
2 files changed
+239 -11

No files matched your search

+131 -9
View File
@@ -1,8 +1,9 @@
#!/usr/bin/env bash
# Deterministic RED suite for /prune-memory — RED-1, RED-2, RED-5, RED-6, RED-7, RED-9.
# Deterministic RED suite for /prune-memory — RED-1, RED-2, RED-5, RED-6,
# RED-7, RED-9, RED-10.
# Each MUST be red on the current (v1) skill. Pure mechanical oracles,
# no LLM. Faithful: RED-2/RED-6/RED-9 execute the REAL bash blocks extracted
# from SKILL.md (no copy that could drift).
# no LLM. Faithful: RED-2/RED-6/RED-9/RED-10 execute the REAL bash blocks
# extracted from SKILL.md (no copy that could drift).
#
# Sandbox only (mktemp). NEVER touches real registries or the repo.
# Usage: bash run-deterministic.sh (exit 0 = all green, 1 = >=1 red)
@@ -17,11 +18,11 @@ fail=0
red() { printf 'RED-%s: RED (skill defective, expected pre-GREEN) -- %s\n' "$1" "$2"; fail=1; }
green() { printf 'RED-%s: GREEN (skill fixed) -- %s\n' "$1" "$2"; }
# Pull the real fenced ```bash block under a "## <heading>" from SKILL.md.
# Pull the real fenced ```bash block under a "#.. <heading>" from SKILL.md.
# Verified by the extract-check before the suite was written.
extract_block() {
awk -v h="$1" '
$0 ~ "^## " h "( |$)" {f=1}
$0 ~ "^#+ " h "( |$)" {f=1}
f && /^```bash/ {c=1; next}
f && /^```/ && c {c=0; f=0; next}
c {print}
@@ -114,10 +115,12 @@ printf '## BDR-901 — old idea [proposed] (2026-01-01)\n- **Context**: resolved
printf '## BDR-902 — kept [accepted] (2026-02-01)\n- **Status (2026-03-01)**: superseded by BDR-903\n' \
>> "$S9A/.claude/memory/decisions.md"
printf '## BLK-903 — c\n- **Status**: upstream\n' > "$S9A/.claude/memory/blockers.md"
printf '## BDR-904 — x\ndate: 2026-01-01 · status: accepted\n\n' > "$S9B/.claude/memory/decisions.md"
printf '## BDR-905 — y\nStatus: closed.\n\n' >> "$S9B/.claude/memory/decisions.md"
printf '## BDR-906 — z\nStatus: proposed\n- **Statut** : accepted (2026-05-01)\n\n' \
>> "$S9B/.claude/memory/decisions.md"
{
printf '## BDR-904 — x\ndate: 2026-01-01 · status: accepted\n\n'
printf '## BDR-905 — y\nStatus: closed.\n\n'
printf '## BDR-906 — z\nStatus: proposed\n'
printf -- '- **Statut** : accepted (2026-05-01)\n\n'
} > "$S9B/.claude/memory/decisions.md"
printf '## BDR-907 — w\n- Status: proposed\nSuperseded by BDR-911 (2026-05-01).\n' \
>> "$S9B/.claude/memory/decisions.md"
extract_block "STEP 1" > "$SANDBOX/step1.sh"
@@ -144,6 +147,125 @@ else
red 9 "$msg9"
fi
# ---- RED-10: STEP 1.D reads FEEDBACK.md for THIS repo's tag -----------------
# Runs the shipped D block in a sandbox repo, HOME pinned to a sandbox dir
# holding .claude/memory-feedback/, like RED-9 (memory.sh by absolute path).
S10="$SANDBOX/red10"; H10="$SANDBOX/home10"
mkdir -p "$S10/.claude/memory" "$H10/.claude/memory-feedback"
git -C "$S10" init -q
printf -- '---\nformat: 2\n---\n# Blockers\n\n'\
'## BLK-905 — x [resolved] (2026-01-01)\n- **Real cause**: y\n' \
> "$S10/.claude/memory/blockers.md"
printf -- '---\nformat: 2\n---\n# Learnings\n\n'\
'## LRN-906 — z (2026-01-01)\n- **Apply**: w\n' \
> "$S10/.claude/memory/learnings.md"
git -C "$S10" add -A
git -C "$S10" -c user.email=t@t -c user.name=t commit -qm seed >/dev/null 2>&1
ROOT10="$(git -C "$S10" rev-parse --show-toplevel)"
TAG10="$(basename "$ROOT10")#$(printf '%s' "$ROOT10" | sha1sum | cut -c1-6)"
FB10="$H10/.claude/memory-feedback/FEEDBACK.md"
extract_block "D. Feedback" > "$SANDBOX/step1d.sh"
run10() { ( cd "$S10" && HOME="$H10" bash "$SANDBOX/step1d.sh" 2>&1 ); }
feedback10() { # $1 = tag of the items, $2 = file
{
printf '# Memory feedback (2026-11-12)\n\nNoisy: none\n'
printf 'Noisy: %s LRN-905, other#abc123 BDR-001\n' "$1"
printf 'Promotion candidates: %s LRN-906, %s BLK-907\n\n' "$1" "$1"
printf 'Actions:\n- noisy: /prune-memory rewrites %s LRN-905\n' "$1"
} > "$2"
}
rows10() { printf '%s\n' "$1" | /usr/bin/grep -E '^(noisy|promote)'"$TAB"; }
msg10=""
# (a) this repo's tag: both row kinds, header lines, the other tag named
feedback10 "$TAG10" "$FB10"
out10="$(run10)"
has9 "$out10" "tag${TAB}$TAG10" || msg10="a: tag header missing"
has9 "$out10" "date${TAB}2026-11-12" || msg10="${msg10:-a: date header missing}"
has9 "$out10" "noisy${TAB}LRN-905" || msg10="${msg10:-a: noisy row missing}"
has9 "$out10" "promote${TAB}LRN-906" \
|| msg10="${msg10:-a: promote LRN-906 missing}"
has9 "$out10" "promote${TAB}BLK-907" \
|| msg10="${msg10:-a: promote BLK-907 missing}"
has9 "$out10" "other${TAB}other#abc123" \
|| msg10="${msg10:-a: other row missing}"
[ "$(rows10 "$out10" | wc -l)" -eq 3 ] \
|| msg10="${msg10:-a: not exactly 3 rows}"
# (a2) a malformed ID is skipped silently; a subdirectory run reads the
# same registries (root-relative) and gives the same 3 rows as (a)
mkdir -p "$S10/sub"
{ printf '# Memory feedback (2026-11-12)\n\n'
printf 'Noisy: %s LRN-905, %s BDR-1 (x\n' "$TAG10" "$TAG10"
printf 'Promotion candidates: %s LRN-906, %s BLK-907\n' "$TAG10" "$TAG10"
} > "$FB10"
out10="$(run10)"
printf '%s\n' "$out10" | /usr/bin/grep -q 'BDR-1' \
&& msg10="${msg10:-a2: malformed ID produced output}"
out10="$( cd "$S10/sub" && HOME="$H10" bash "$SANDBOX/step1d.sh" 2>&1 )"
[ "$(rows10 "$out10" | wc -l)" -eq 3 ] \
|| msg10="${msg10:-a2: subdir run: not 3 rows}"
# (b) another tag only: no noisy/promote row, the tag named as other
feedback10 "zzz#000000" "$FB10"
out10="$(run10)"
[ -z "$(rows10 "$out10")" ] || msg10="${msg10:-b: a row for a foreign tag}"
has9 "$out10" "other${TAB}zzz#000000" || msg10="${msg10:-b: other row missing}"
# (c) no FEEDBACK.md
rm -f "$FB10"
out10="$(run10)"
[ "$out10" = "no-feedback-run" ] || msg10="${msg10:-c: got: $out10}"
# (d) the tag the block computes equals labels.ts tagOf (bun only)
if command -v bun >/dev/null 2>&1; then
labels10="$HERE/../../../lib/memory-feedback/labels.ts"
bun10="import { tagOf } from '$labels10'; "
bun10+="console.log(tagOf(process.argv[1]))"
tag10="$(bun -e "$bun10" "$ROOT10" 2>&1)"
feedback10 "$tag10" "$FB10"
out10="$(run10)"
has9 "$out10" "noisy${TAB}LRN-905" \
|| msg10="${msg10:-d: block tag differs from tagOf ($tag10 vs $TAG10)}"
else
echo "RED-10d: SKIP (bun absent, tagOf comparison not run)"
fi
# (e) memory.sh status with "<word>, promoted to": rc 0, the word stays,
# and the D block drops both promote rows
feedback10 "$TAG10" "$FB10"
for st in 'BLK-905|resolved, promoted to guard test' \
'LRN-906|implemented, promoted to hook'; do
( cd "$S10" && HOME="$H10" bash "$HERE/../../../lib/memory.sh" \
status "${st%%|*}" "${st#*|}" >/dev/null 2>&1 ) \
|| msg10="${msg10:-e: memory.sh status refused ${st%%|*}}"
done
idx10="$( cd "$S10" && HOME="$H10" bash "$HERE/../../../lib/memory.sh" \
index blocker 2>&1 )"
printf '%s\n' "$idx10" | /usr/bin/grep -qE '^\| BLK-905 .*\| resolved \|$' \
|| msg10="${msg10:-e: BLK-905 word changed after the status line}"
out10="$(run10)"
printf '%s\n' "$out10" | /usr/bin/grep -qE "^promote${TAB}(LRN-906|BLK-905)" \
&& msg10="${msg10:-e: a promoted row survived}"
has9 "$out10" "promote${TAB}BLK-907" || msg10="${msg10:-e: BLK-907 row lost}"
# (f) outside a git repo
out10="$( cd "$SANDBOX" && HOME="$H10" bash "$SANDBOX/step1d.sh" 2>&1 )"
[ "$out10" = "no-git-root" ] || msg10="${msg10:-f: got: $out10}"
# (g) a curation commit subject carrying the token drops the noisy row
printf '\n' >> "$S10/.claude/memory/learnings.md"
git -C "$S10" add -A
git -C "$S10" -c user.email=t@t -c user.name=t \
commit -qm 'chore(memory): noisy-rewrite LRN-905' >/dev/null 2>&1
out10="$(run10)"
has9 "$out10" "noisy${TAB}LRN-905" && msg10="${msg10:-g: noisy row not dropped}"
if [ -z "$msg10" ]; then
green 10 "D block: tag match, foreign tag, absent file, drops, no-git-root"
else
red 10 "$msg10"
fi
echo "----"
if [ "$fail" -eq 0 ]; then
echo "SUITE: all GREEN"