From 1fb07050da62e7b2be675f9d08e67a3b22ea8d99 Mon Sep 17 00:00:00 2001 From: bchanot Date: Mon, 2 Nov 2026 01:38:59 +0100 Subject: [PATCH] chore(routing): skill census globs pack skills; long-name rows for pack skills; every row resolves to a skill --- lib/skill-routing-census.py | 1 + lib/tests/effort-routing.test.sh | 17 +++++++++++++++++ mods/model-router/routing.json | 17 +++++++++++++++++ 3 files changed, 35 insertions(+) diff --git a/lib/skill-routing-census.py b/lib/skill-routing-census.py index 89cb70f..dadca0e 100644 --- a/lib/skill-routing-census.py +++ b/lib/skill-routing-census.py @@ -25,6 +25,7 @@ import sys DEFAULT_ROOTS = ["~/.claude/skills", "~/.claude/plugins/cache"] ROOT_SUFFIXES = [ "*/SKILL.md", + "pack-*/skills/*/SKILL.md", "*/*/*/skills/*/SKILL.md", "*/*/*/.claude/skills/*/SKILL.md", ] diff --git a/lib/tests/effort-routing.test.sh b/lib/tests/effort-routing.test.sh index c4bdc22..b56d428 100755 --- a/lib/tests/effort-routing.test.sh +++ b/lib/tests/effort-routing.test.sh @@ -158,6 +158,23 @@ check_skill() { while IFS= read -r f; do check_skill "$f"; done < <( cd "$R" && git ls-files 'skills/*/SKILL.md' 'skills-external/*/SKILL.md') +# ── (b2) every skills row resolves to a skill (short, pack entry, parked) ─ +row_resolves() { # row_resolves + local k="$1" n + case "$k" in + pack-*:*) n="${k%%:*}"; [ -e "$R/skills/$n/skills/${k#*:}/SKILL.md" ];; + *) [ -e "$R/skills/$k/SKILL.md" ] || [ -n "$(skdir "$k")" ] \ + || [ -e "$R/skills-external/$k/SKILL.md" ];; + esac +} +[ -n "$(skdir seo)" ] && ! row_resolves ghost-skill \ + && ! row_resolves pack-seo:ghost && ! row_resolves pack-ghost:seo \ + && ok || ko "row_resolves: flip-test (ghost rows must fail)" +while read -r kind key _; do + [ "$kind" = skills ] || continue + row_resolves "$key" && ok || ko "routing.json: skills row '$key' resolves to no skill" +done <<< "$RD" + # ── (c) tracked agents with a row: tier floor == model:, effort == effort: ─ NO_ROW_AGENTS=" interviewer client-handover-writer " check_agent() { diff --git a/mods/model-router/routing.json b/mods/model-router/routing.json index 1f5cbb9..c48c563 100644 --- a/mods/model-router/routing.json +++ b/mods/model-router/routing.json @@ -74,6 +74,7 @@ "writing-plans": "plan", "requesting-code-review": "plan", "21st-ui-review": "plan", + "pack-extras:21st-ui-review": "plan", "feat": "reflect", "hotfix": "reflect", "bugfix": "reflect", @@ -82,24 +83,39 @@ "guardrails": "reflect", "a11y": "reflect", "web-validate": "reflect", + "pack-web-validate:web-validate": "reflect", "harden": "reflect", "seo": "reflect", + "pack-seo:seo": "reflect", "geo": "reflect", + "pack-seo:geo": "reflect", "site-motion": "reflect", + "pack-design:site-motion": "reflect", "frontend-design": "reflect", + "pack-design:frontend-design": "reflect", "emil-design-eng": "reflect", + "pack-design:emil-design-eng": "reflect", "design-motion-principles": "reflect", + "pack-design:design-motion-principles": "reflect", "21st-ui-build": "reflect", + "pack-design:21st-ui-build": "reflect", "scroll-world-storytelling": "reflect", + "pack-scroll3d:scroll-world-storytelling": "reflect", "build-threejs-scroll-worlds": "reflect", + "pack-scroll3d:build-threejs-scroll-worlds": "reflect", "scroll-scrubbed-visual-sequence": "reflect", + "pack-scroll3d:scroll-scrubbed-visual-sequence": "reflect", "scroll-scrubbed-word-reveal": "reflect", + "pack-scroll3d:scroll-scrubbed-word-reveal": "reflect", "scroll-progress-timeline": "reflect", + "pack-scroll3d:scroll-progress-timeline": "reflect", "subagent-driven-development": "reflect", "writing-skills": "reflect", "deprecation-and-migration": "reflect", "21st-ai": "reflect", + "pack-extras:21st-ai": "reflect", "21st-ui-explore": "reflect", + "pack-extras:21st-ui-explore": "reflect", "gitflow": "implement", "prune-memory": "implement", "pdf-translate": "implement", @@ -119,6 +135,7 @@ "skills-perso": "mechanical", "using-git-worktrees": "mechanical", "21st-cli-use": "mechanical", + "pack-design:21st-cli-use": "mechanical", "21st-registry": "mechanical", "21st-design-sync": "mechanical" },