diff --git a/.claude/memory/decisions.md b/.claude/memory/decisions.md index d6181ab..632bdf2 100644 --- a/.claude/memory/decisions.md +++ b/.claude/memory/decisions.md @@ -1470,6 +1470,7 @@ Branch feature/user-writing-web-rules, UNMERGED (human gate). - **Accepted risks**: `cc.sh` keeps `set -a; . ~/.claude/.env` (all secrets in the claude env, as `dtach_claude` did); `deniedMcpServers` union = `cc x web` on a `dev` project keeps the connectors denied (`set web` in the project fixes it). - **Branch**: feature/phase5-profiles-packs; spec docs/superpowers/specs/2026-11-01-phase5-profiles-packs-design.md; contract .claude/tasks/contracts/2026-11-01-phase5-profiles-packs-1300.md. Supersedes [[BDR-030]]. +- **Status (2026-11-09)**: accepted, amended 2026-11-09: higgsfield connector denies + census connector rule removed after claude.ai account removal (chore/connector-deny-cleanup); generic deniedMcpServers mechanism in profile.sh kept ## BDR-135 — model-router askTier: consent before Fable, tier-name choice stamped on turn and run slots, per-type spawn memory [accepted] (2026-11-02) - **Context**: user ask 2026-11-02: model-router must ask before routing main or a rowed spawn onto Fable. feature/router-ask-tier, contract `.claude/tasks/contracts/2026-11-02-router-ask-tier-1434.md`, plan r3 after 3 lenses + confirmation. diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index d314d24..c5c5620 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -709,3 +709,4 @@ rules: ## 2026-11-09 - 2026-11-09: BDR-125 residual measured: 30.2k→40k = Skills +6.2k (budget paid claude.ai-synced skills) + System tools (unattributable). /feat claude-ai-skills-off: global skillOverrides 19 off, 47438f4 + 07406ce; GATE 0 MET, verifier ECARTS(1)→CONFORME, security PASS. User removed claude.ai connectors. BDR-141, LRN-270/271. Merge on signal; next: dead deniedMcpServers cleanup. +- 2026-11-09: /ship-feature connector-deny-cleanup (chore): dead higgsfield deniedMcpServers + census rule + prose citers removed, 12 files, T13 deny-set test; challenge 3x SOLID, verifier ECARTS x2 (revert hint) -> CONFORME, security PASS x3, opus review fixes. BDR-134 amended, LRN-272/273. Merge on signal. diff --git a/.claude/memory/learnings.md b/.claude/memory/learnings.md index 9d1bc46..5fc1f47 100644 --- a/.claude/memory/learnings.md +++ b/.claude/memory/learnings.md @@ -2006,3 +2006,13 @@ Rule: when editing a doctrine file under structure locks, grep the test's lock s - **Pattern**: contract CHECK running `make test` here → NOT-MET `timeout=120s` under gates.sh default, and red memory/memory-feedback suites when `bun` not on PATH. Run gate as `GATES_TIMEOUT=600 PATH="$HOME/.bun/bin:$PATH" bash ~/.claude/lib/gates.sh run `. - **Context**: /feat claude-ai-skills-off 2026-11-09: feater reported criterion 3 red (bun), first GATE 0 NOT-MET on timeout though suite green (rc 0, all suites green). - **Future use**: every contract with a `make test` oracle in this repo: brief executor + gate run with both env vars; consider default timeout per contract. + +## LRN-272 — Revert hints name the --no-ff merge, never a commit count (2026-11-09) +- **Pattern**: CHANGELOG/doc revert hint names the `--no-ff` merge (`git revert -m 1 `), never a commit count or per-commit list. Fix commits shift the count; reverting a commit whose line a later fix rewrote conflicts (`git merge-tree` rc 1). +- **Context**: chore/connector-deny-cleanup 2026-11-09: hint "revert the chore(profiles) commit" → final review: misses docs commit → fix "two commits" → opus review: 3 commits now, conflict simulated → merge form. Two fix rounds for one sentence. +- **Future use**: any "how to undo" line in CHANGELOG/MIGRATION: point at the merge gitflow finish creates (lib/gitflow.sh --no-ff). + +## LRN-273 — ship-feature on a chore branch: plan goes to .claude/tasks/plans (purge only on feature/bugfix) (2026-11-09) +- **Pattern**: `gitflow finish` purges transient `docs/superpowers/{specs,plans}` only on feature/bugfix branches (BDR-065, `_gitflow_purge_transient`). /ship-feature on a `chore/*` branch (cleanup, no new behavior per gitflow doctrine) → write the plan to `.claude/tasks/plans/--.md` (durable, allowlisted), else transient plan lands on develop. +- **Context**: 2026-11-09 connector-deny cleanup via /ship-feature: writing-plans default path docs/superpowers/plans; caught by the transient-artifacts path rule before commit, plan moved. +- **Future use**: ship-feature STEP 4 says `start feature`; when doctrine says chore, also move the plan path. Candidate: ship-feature/writing-plans note. diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index a308e1c..3734140 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -109,7 +109,7 @@ Shared rules for every phase: - Dropped by the re-challenge: skill listing filter + routing.json `contexts` + census (phase 5 packs + the budget env already give 0 name-only); routing-hint classifier (no measured miss outside code intents the phase 2 guard catches; the "Skill routing" table lines move into our own skills' `description:`, ≤3 lines for vendored aliases stay in CLAUDE.global.md, done in phase 1 cleanup); agent listing rewrite (phase 1 diet); higgsfield deltas (phase 0/5); project fingerprint. `prompt.attachment` kinds (`skill_listing`, `agent_listing_delta`…) exist in the 2.1.306 types but not in the docs text: re-verify at build time. - [x] Measure the 30.2k → 40k rise (2026-11-09, LRN-270): Skills +6.2k = budget 50000 paying mostly claude.ai-synced skills; System tools rise not attributable (`/context all` has no per-tool row). Tool-search threshold hypothesis disproved (`ENABLE_TOOL_SEARCH=true` changes nothing; Higgsfield deny on full keeps 7.7k). L1 shipped: feature/claude-ai-skills-off 47438f4 + 07406ce (BDR-141), full headless 32.2k → 28.5k; user removed Higgsfield + unused claude.ai connectors (full 26.9k headless). Merge on user signal. - - [ ] Cleanup run: the 5 profiles' `deniedMcpServers` (audit, dev, minimal, qa, seo) target connectors removed at claude.ai on 2026-11-09: drop them + citers (lib/profiles/README.md:5,11, skills/profile/SKILL.md:26,61, CHANGELOG known-limit line 62); keep the generic profile.sh mechanism (tested with fictional connectors). 8 files of deletions: /ship-feature by rule, or /feat on user OK. + - [x] Cleanup run (2026-11-09, /ship-feature on chore/connector-deny-cleanup b80da29..5413f40, 12 files): denies + census connector rule removed, prose citers rewritten, T13 deny-set variant added; gates MET / CONFORME (3rd pass) / PASS; BDR-134 amended, LRN-272/273. Merge on user signal. Not checked: work machine project settings.local.json (CHANGELOG says delete by hand). - [ ] Open: dev System tools 11.3k vs full 7.7k (interactive) comes from some pack being off, not MCP; unattributable via `/context`. Bisect by toggling one pack at a time interactively if it matters. - [ ] Follow-up candidate (accepted risk): doctor residue check covers `enabledPlugins` only; a UI write into user-scope `skillOverrides` would dirty tracked settings.json unseen. diff --git a/.claude/tasks/contracts/2026-11-09-connector-deny-cleanup-1523.md b/.claude/tasks/contracts/2026-11-09-connector-deny-cleanup-1523.md new file mode 100644 index 0000000..7f6f9ec --- /dev/null +++ b/.claude/tasks/contracts/2026-11-09-connector-deny-cleanup-1523.md @@ -0,0 +1,55 @@ +# CONTRACT — connector-deny-cleanup +- date: 2026-11-09 | flow: ship-feature | branch: chore/connector-deny-cleanup +- status: active + +## REQUEST (verbatim — IMMUTABLE) +Cleanup (user-approved 2026-11-09): the claude.ai Higgsfield connectors ("claude.ai higgsfield", "claude.ai Higgsfield AI") were removed at the claude.ai account level by the user on 2026-11-09 (verified headless: only Claude Docs connector left). The `deniedMcpServers` entries in lib/profiles/{audit,dev,minimal,qa,seo}.json are now dead. Remove them and every citer: the census rule in lib/pack-census-fragments.jq (lines ~3, 28-30: "must deny both higgsfield connectors") + its test fixtures in lib/tests/pack-census.test.sh, the comment in lib/pack-census.sh:14, lib/profiles/README.md (lines 5, 11-13), skills/profile/SKILL.md (lines 26, 61-63), CHANGELOG [Unreleased] (known-limit line ~62 + new entry). KEEP the generic deniedMcpServers mechanism in lib/profile.sh / lib/profile-state.jq and its tests (lib/tests/profile.test.sh uses fictional connectors X/Y): it serves any future connector. No new behavior; grep every citer (doctrine-citers census in make test). make test runs with GATES_TIMEOUT=600 and PATH=$HOME/.bun/bin:$PATH (LRN-271). Context: BDR-141, BDR-134, TODO "Cleanup run" item under Context mod queue. + +User words (2026-11-09): "merge et on attaque le nettoyage"; flow pick "/ship-feature". + +## CLARIFICATIONS +Q: premise, are the connectors really gone (this session still shows them)? / A: this session predates the removal; a fresh headless session after the removal listed only Claude Docs (8 tools), 0 higgsfield tool. Verified by the orchestrator 2026-11-09. +Q: orphaned denies in project settings.local.json? / A: 0 of the projects on this machine carry `deniedMcpServers` (find over ~/ depth 5, analyzer: 0 of 13 in ~/.claude.json); profiles never shipped in a release (absent from v2.0.0 and earlier). Not checked: the manual-push work machine (BDR-111); the CHANGELOG bullet tells it to delete leftover entries by hand. [gated 2026-11-09, robustness challenge] + +Q: census connector rule after removal? / A: delete it entirely (no "no deny" invariant); `dn` stays in the identical-fragment check. [gated 2026-11-09] +Q: CHANGELOG for never-released profiles? / A: correct [Unreleased] in place (drop the union known-limit line, trim the 2026-11-02 deny-profile mention, one Changed bullet). [gated 2026-11-09] +Q: union note in skills/profile/SKILL.md? / A: delete it (LRN-270 keeps the fact). [gated 2026-11-09] +Q: design (brainstorm, bounded) approved? / A: yes. [gated 2026-11-09] +Q: (code review) CHANGELOG revert hint miscounts commits? / A: name the merge: "revert the merge of `chore/connector-deny-cleanup` into develop (`git revert -m 1 `), which restores the denies, their census rule and the docs". [gated 2026-11-09] +Q: (code review) `design` list line purpose? / A: append "; UI and visual design work." [gated 2026-11-09] +Q: (code review) minors? / A: add "(dev, qa and seo denied the connectors at the time)" to the 2026-11-02 measurement line; add a T13 variant: a fragment identical to dev.json except a fictional deny is NOT reported identical. [gated 2026-11-09] + +## ACCEPTANCE CRITERIA +1. No profile fragment carries `deniedMcpServers`; positive control: develop's dev.json does (the check can fail). + CHECK: cd /home/bchanot/Documents/claude && git show develop:lib/profiles/dev.json | jq -e 'has("deniedMcpServers")' >/dev/null && for f in lib/profiles/*.json; do jq -e 'has("deniedMcpServers") | not' "$f" >/dev/null || { echo "still: $f"; exit 1; }; done && echo NO-FRAGMENT-DENY + EXPECT: NO-FRAGMENT-DENY + EVIDENCE: MET exit=0 marker-found :: NO-FRAGMENT-DENY +2. No tracked file outside history names the two connectors or the deny-profile list, and the profile docs no longer describe profiles by connector state (the generic `connectors denied:` output label of lib/profile.sh / profile-state.jq and its fictional-connector tests stay); positive control: develop's tree matches both patterns. + CHECK: cd /home/bchanot/Documents/claude && a='claude\.ai higgsfield|claude\.ai Higgsfield AI|DENY_PROFILES|higgsfield connectors|connecteurs higgsfield' && b='connectors present|connectors denied|deny set' && docs='lib/profiles/README.md skills/profile/SKILL.md lib/tests/pack-census.test.sh' && git grep -q -E "$a" develop -- ':!.claude' ':!skills-external' ':!CHANGELOG.md' && git grep -q -E "$b" develop -- $docs && ! git grep -n -E "$a" -- ':!.claude' ':!skills-external' ':!CHANGELOG.md' && ! git grep -n -E "$b" -- $docs && echo NO-CONNECTOR-CITER + EXPECT: NO-CONNECTOR-CITER + EVIDENCE: MET exit=0 marker-found :: NO-CONNECTOR-CITER +3. The generic connector-deny mechanism and its tests are untouched. + CHECK: cd /home/bchanot/Documents/claude && git diff --quiet develop -- lib/profile.sh lib/profile-state.jq lib/tests/profile.test.sh && grep -q 'managed_connectors' lib/profile.sh && echo MECHANISM-KEPT + EXPECT: MECHANISM-KEPT + EVIDENCE: MET exit=0 marker-found :: MECHANISM-KEPT +4. The pack census passes on the real repo and its suite is green. + CHECK: cd /home/bchanot/Documents/claude && bash lib/pack-census.sh 2>&1 | grep -q '^PACKS OK' && make test suite=lib/tests/pack-census.test.sh 2>&1 | tail -3 | grep -q 'all suites green' && echo CENSUS-OK + EXPECT: CENSUS-OK + EVIDENCE: MET exit=0 marker-found :: CENSUS-OK +5. The repo suite stays green (run with GATES_TIMEOUT=600 and PATH=$HOME/.bun/bin:$PATH). + CHECK: cd /home/bchanot/Documents/claude && make test 2>&1 | tail -3 | grep -q 'all suites green' && echo SUITE-OK + EXPECT: SUITE-OK + EVIDENCE: MET exit=0 marker-found :: SUITE-OK +6. Prose citers are rewritten, not just cut: lib/profiles/README.md (`- **name**: text` shape kept for `profile.sh list`, invariants paragraph without the deny clause), skills/profile/SKILL.md, USAGE.md, CHANGELOG `[Unreleased]` (no known-limit line about the union of higgsfield denies, the 2026-11-02 measurement line no longer presents deny profiles as shipped behavior, one entry saying the profiles deny no connector since the account removal); no em-dash in new prose. + +7. [gated 2026-11-09] The read-only profile verbs work on the real repo with no fragment deny: `list` prints 9 profiles and no `(no line in lib/profiles/README.md)`; `show dev` says `connectors denied: none`; `diff dev` prints no `connectors denied:` line. + CHECK: cd /home/bchanot/Documents/claude && l=$(bash lib/profile.sh list) && [ "$(printf '%s\n' "$l" | grep -c -E '^(full|max|minimal|dev|design|web|seo|qa|audit) ')" = 9 ] && ! printf '%s\n' "$l" | grep -q 'no line in lib/profiles/README.md' && bash lib/profile.sh show dev | grep -q 'connectors denied: none' && ! bash lib/profile.sh diff dev | grep -q 'connectors denied:' && echo VERBS-OK + EXPECT: VERBS-OK + EVIDENCE: MET exit=0 marker-found :: VERBS-OK +8. [gated 2026-11-09] The identical-fragment check still compares the deny set (`dn` kept), and the census jq no longer reads a `$deny` argument. + CHECK: cd /home/bchanot/Documents/claude && grep -q '^def dn:' lib/pack-census-fragments.jq && grep -q '\.d == \$e\.value\.d' lib/pack-census-fragments.jq && ! grep -q '\$deny' lib/pack-census-fragments.jq && ! grep -q -- '--arg deny' lib/pack-census.sh && echo DN-KEPT + EXPECT: DN-KEPT + EVIDENCE: MET exit=0 marker-found :: DN-KEPT + +## FILE SCOPE +lib/profiles/{audit,dev,minimal,qa,seo}.json, lib/pack-census-fragments.jq, lib/pack-census.sh, lib/tests/pack-census.test.sh, lib/profiles/README.md, skills/profile/SKILL.md, USAGE.md, CHANGELOG.md diff --git a/.claude/tasks/plans/2026-11-09-connector-deny-cleanup-1523.md b/.claude/tasks/plans/2026-11-09-connector-deny-cleanup-1523.md new file mode 100644 index 0000000..fcca678 --- /dev/null +++ b/.claude/tasks/plans/2026-11-09-connector-deny-cleanup-1523.md @@ -0,0 +1,262 @@ +# Connector deny cleanup Implementation Plan + +> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking. + +**Goal:** Remove the dead claude.ai Higgsfield connector denies from five profile fragments, the census rule that enforced them, and every prose citer, keeping the generic `deniedMcpServers` mechanism of `lib/profile.sh`. + +**Architecture:** Two tasks. Task 1 changes data and its checker together (the five JSON fragments, the census rule in `lib/pack-census-fragments.jq`, its caller `lib/pack-census.sh`, its suite `lib/tests/pack-census.test.sh`): they are coupled, a partial change turns the census red. Task 2 rewrites the prose that describes profiles by connector state. + +**Tech Stack:** bash, jq 1.8, markdown. Tests: `make test suite=lib/tests/pack-census.test.sh`, then full `make test`. + +**Spec:** contract `.claude/tasks/contracts/2026-11-09-connector-deny-cleanup-1523.md` (REQUEST verbatim, CLARIFICATIONS `[gated 2026-11-09]`: delete the census connector rule entirely, correct CHANGELOG `[Unreleased]` in place, delete the union note in skills/profile/SKILL.md). + +## Global Constraints + +- Branch `chore/connector-deny-cleanup` off develop (cleanup, no new behavior). Never commit on develop. Never `gitflow.sh finish`. +- Do NOT modify `lib/profile.sh`, `lib/profile-state.jq`, `lib/tests/profile.test.sh` (generic mechanism, contract criterion 3). +- Foreign code style: keep each file's existing style, inline, no new helper. +- Max 80 chars/line in `lib/pack-census.sh` (T12-width lock); shellcheck clean. +- No em-dash in new prose. Profile description lines in `lib/profiles/README.md` keep the exact shape `- **name**: text` (parsed by `profile.sh list`). +- In files other than CHANGELOG.md, `.claude/`, `skills-external/`: no occurrence of `claude.ai higgsfield`, `claude.ai Higgsfield AI`, `DENY_PROFILES`, `higgsfield connectors`, `connecteurs higgsfield`; in `lib/profiles/README.md`, `skills/profile/SKILL.md`, `lib/tests/pack-census.test.sh`: no `connectors present`, `connectors denied`, `deny set` (contract criterion 2). +- Full suite command: `GATES_TIMEOUT=600 PATH="$HOME/.bun/bin:$PATH" make test` (LRN-271: needs bun, > 120 s). +- Line numbers in this plan are PRE-EDIT; they shift after an earlier edit in the same file. Match on the quoted old text, never on the number. + +## Review Focus + +- The identical-fragment check still compares the deny set (`dn` stays in `lib/pack-census-fragments.jq:6` and :13-16); a future fragment with a deny must not be reported identical to one without. No test exercises it today (pre-existing); not added (YAGNI, contract scope). +- jq program structure after deleting the rule block: the generator list must stay well-formed (every item separated by `,`); verified by T1 green and T11 real-repo green. +- `profile.sh list` output after the README edit: three description lines lose their connector clause; run `bash lib/profile.sh list` and check 9 lines (format `printf '%-10s %s'`: padded name, then text) and no line containing `(no line in lib/profiles/README.md)`. +- The new production state (no fragment denies anything, `managed_connectors` empty) is not covered by lib/tests/profile.test.sh (frozen, its fixtures always deny X/Y): smoke the read-only verbs on the real repo in Task 1 Step 7. +- A project already holding the two denies in `.claude/settings.local.json` (none on this machine) keeps them; `profile.sh unset` will not strip them any more. Documented in the CHANGELOG bullet, no code. +- `dn` unused warning: jq has none; nothing to do. + +--- + +### Task 1: Fragments and census without the connector rule + +**Files:** +- Modify: `lib/tests/pack-census.test.sh:4`, `:29-33`, `:89`, `:92` +- Modify: `lib/pack-census-fragments.jq:1-4`, `:10`, `:28-33` +- Modify: `lib/pack-census.sh:12-15`, `:38`, `:78` +- Modify: `lib/profiles/audit.json`, `lib/profiles/dev.json`, `lib/profiles/minimal.json`, `lib/profiles/qa.json`, `lib/profiles/seo.json` (drop `deniedMcpServers`) + +**Interfaces:** +- Consumes: nothing. +- Produces: `lib/pack-census.sh` called as before (`[--repo ] [--installed]`), no `--arg deny` to the jq program; `frag()` test helper with 3 params `name alpha beta`. + +- [ ] **Step 1: Write the failing test (fixture without denies)** + +In `lib/tests/pack-census.test.sh` replace lines 29-33: + +```bash +frag() { # name alpha beta deny(yes|no) — the two real connector names + local d=""; [ "$4" = yes ] && d=', "deniedMcpServers": [{"serverName": "claude.ai higgsfield"}, {"serverName": "claude.ai Higgsfield AI"}]' + printf '{"enabledPlugins": {"model-router@skills-dir": true, "pack-alpha@skills-dir": %s, "pack-beta@skills-dir": %s, "security-guidance@claude-code-plugins": true, "example-skills@anthropic-agent-skills": false, "brightdata-plugin@synced": false}%s}\n' \ + "$2" "$3" "$d" > "$FX/lib/profiles/$1.json"; } +frag full true false no; frag dev false false yes +``` + +with: + +```bash +frag() { # name alpha beta + printf '{"enabledPlugins": {"model-router@skills-dir": true, "pack-alpha@skills-dir": %s, "pack-beta@skills-dir": %s, "security-guidance@claude-code-plugins": true, "example-skills@anthropic-agent-skills": false, "brightdata-plugin@synced": false}}\n' \ + "$2" "$3" > "$FX/lib/profiles/$1.json"; } +frag full true false; frag dev false false +``` + +Line 89 `frag full true true no` becomes `frag full true true`; line 92 `frag full true false no` becomes `frag full true false`. + +Line 4 `# fragment invariants (same key set, fixed values, deny set, full = manifest` becomes `# fragment invariants (same key set, fixed values, full = manifest`. + +- [ ] **Step 2: Run the suite, verify it fails** + +Run: `make test suite=lib/tests/pack-census.test.sh` +Expected: FAIL on T1-green-rc, T1-green, T2-off-dangling-rc and T3-on-dangling-test-rc (the fixture `dev.json` now denies nothing while the census still requires both denies on `dev`: `RED lib/profiles/dev.json: must deny both higgsfield connectors`, and that RED persists across the census runs those cases make). + +- [ ] **Step 3: Remove the rule from the jq program** + +`lib/pack-census-fragments.jq` lines 1-4 (the header, ending `# and WARN lines for a pack id with no manifest.`) become: + +```jq +# lib/pack-census-fragments.jq — fragment invariants (lib/pack-census.sh). +# $m = manifests [{id,on}]; inputs = lib/profiles/*.json. Prints RED lines, +# and WARN lines for a pack id with no manifest. +``` + +Delete line 10: + +```jq +| ($deny | split(" ") | map(. + ".json")) as $deny_files +``` + +Delete lines 28-33 (the whole generator item, including its trailing comma): + +```jq + ( (["claude.ai higgsfield", "claude.ai Higgsfield AI"] | sort) as $both + | if (($deny_files | index($f)) != null) and (($g | dn) != $both) + then "RED lib/profiles/\($f): must deny both higgsfield connectors" + elif (($deny_files | index($f)) == null) and (($g | dn) | length) > 0 + then "RED lib/profiles/\($f): must deny no connector" + else empty end ), +``` + +Keep `def dn` (line 6) and its use in the identical-fragment check. + +- [ ] **Step 4: Remove the deny list from the caller** + +`lib/pack-census.sh` lines 12-15: + +```bash +# 2. fragments lib/profiles/*.json: same key set as full.json; model-router +# + security-guidance true, example-skills + brightdata false +# everywhere; the two higgsfield connectors denied on exactly +# DENY_PROFILES; full.json packs = manifest defaults. +``` + +become: + +```bash +# 2. fragments lib/profiles/*.json: same key set as full.json; model-router +# + security-guidance true, example-skills + brightdata false +# everywhere; full.json packs = manifest defaults. +``` + +Delete line 38: `DENY_PROFILES="audit dev minimal qa seo" # spec § 2`. + +Line 78 ` out="$(jq -rn --arg deny "$DENY_PROFILES" --argjson m "$(manifests_json)" \` becomes: + +```bash + out="$(jq -rn --argjson m "$(manifests_json)" \ +``` + +- [ ] **Step 5: Run the suite, verify fixtures and T11 pass** + +Run: `make test suite=lib/tests/pack-census.test.sh` +Expected: T1..T10, T13, T14, T12 pass. T11 still passes too (the real fragments carry denies and no rule forbids them any more). Note it: removing the rule alone does not flag the dead data, so Step 6 is driven by contract criterion 1, not by T11. + +- [ ] **Step 6: Drop the denies from the five fragments** + +For each of `audit dev minimal qa seo` (jq round-trip is byte-identical on these files, checked on full.json): + +```bash +for p in audit dev minimal qa seo; do + f="lib/profiles/$p.json" + jq 'del(.deniedMcpServers)' "$f" > "$f.tmp" && mv "$f.tmp" "$f" +done +for f in lib/profiles/*.json; do jq -e 'has("deniedMcpServers") | not' "$f" >/dev/null || echo "still: $f"; done +``` + +Expected: no `still:` line; `git diff --stat lib/profiles` shows 5 files, 9 deletions and 1 change each (the `},` before the block becomes `}`). + +- [ ] **Step 7: Run the suite and the real census** + +Run: `make test suite=lib/tests/pack-census.test.sh && bash lib/pack-census.sh | tail -1 && shellcheck lib/pack-census.sh` +Expected: suite green (T11 `PACKS OK 9 packs 55 skills`), last census line `PACKS OK 9 packs 55 skills`, shellcheck silent. Also `bash lib/profile.sh list` prints 9 profiles. + +Smoke the read-only verbs on the real repo (no write): `bash lib/profile.sh current --plain` (rc 0, `profile=full`), `bash lib/profile.sh show dev` (contains `connectors denied: none`), `bash lib/profile.sh diff dev` (no line starting `connectors denied:`). + +- [ ] **Step 8: Commit** + +```bash +git add lib/tests/pack-census.test.sh lib/pack-census-fragments.jq lib/pack-census.sh lib/profiles/audit.json lib/profiles/dev.json lib/profiles/minimal.json lib/profiles/qa.json lib/profiles/seo.json +git commit -m "chore(profiles): drop the dead higgsfield connector denies and their census rule" +``` + +### Task 2: Prose citers + +**Files:** +- Modify: `lib/profiles/README.md:3-13`, `:17`, `:19`, `:21`, `:27-31` +- Modify: `skills/profile/SKILL.md:25-27`, `:37-38`, `:61-63` +- Modify: `USAGE.md:242` +- Modify: `CHANGELOG.md:62`, `:63`, end of `[Unreleased]` `### Changed` (after the `skillOverrides` bullet, before `### Removed`) + +**Interfaces:** +- Consumes: Task 1 done (profiles carry no deny). +- Produces: none (docs). + +- [ ] **Step 1: Write the failing check (contract criterion 2)** + +```bash +a='claude\.ai higgsfield|claude\.ai Higgsfield AI|DENY_PROFILES|higgsfield connectors|connecteurs higgsfield' +b='connectors present|connectors denied|deny set' +docs='lib/profiles/README.md skills/profile/SKILL.md lib/tests/pack-census.test.sh' +git grep -n -E "$a" -- ':!.claude' ':!skills-external' ':!CHANGELOG.md'; git grep -n -E "$b" -- $docs +``` + +Expected now: hits in lib/profiles/README.md, skills/profile/SKILL.md, USAGE.md (the check fails). + +- [ ] **Step 2: lib/profiles/README.md** + +Lines 3-13 become: + +```markdown +A profile is a literal Claude Code settings fragment: `enabledPlugins` +(every pack `pack-@skills-dir` and managed plugin, explicit), optional +`deniedMcpServers` (claude.ai connectors to deny), optional +`model`. Per project: `bash ~/.claude/lib/profile.sh set ` writes it +into `.claude/settings.local.json`, then `/reload-plugins`. Per +conversation: `cc ` (lib/cc.sh) runs +`claude --settings lib/profiles/.json`; that conversation is frozen +(no reload brings a pack back; relaunch instead). No profile = the manifest +defaults = `full`. +``` + +(Only the parenthetical of line 5 changes, line 11 is cut after `full`, and the union sentence of lines 11-13 goes; lines 6-10 stay byte-identical.) + +Line 17 becomes `- **full**: every pack except higgsfield and extras; ui-ux-pro-max on. The default.` +Line 19 becomes `- **minimal**: no pack, no design plugin; the smallest listing.` +Line 21 becomes `- **design**: design, scroll3d, gstack-design, gstack-browser, ui-ux-pro-max.` + +Lines 27-31 (invariants) become: + +```markdown +Invariants (checked by `lib/pack-census.sh`): the same key set in every +fragment; `model-router@skills-dir` and `security-guidance@claude-code-plugins` +true everywhere; `example-skills@anthropic-agent-skills` and +`brightdata-plugin@synced` false everywhere; `full` equal to the manifest +defaults. +``` + +- [ ] **Step 3: skills/profile/SKILL.md** + +Lines 25-27 become: + +```markdown +`lib/profiles/.json` holds `enabledPlugins` (every pack and managed +plugin, explicit), optional `deniedMcpServers` (claude.ai connectors to +deny) and optional `model`. Descriptions: `lib/profiles/README.md`. +``` + +(Field order kept; only the parenthetical changes.) + +Lines 37-38 (`- No profile: the manifest defaults, which equal \`full\` with the connectors` / `present.`) become `- No profile: the manifest defaults, which equal \`full\`.` + +Delete lines 61-63 (the bullet starting `- \`deniedMcpServers\` is a union across settings files`). + +- [ ] **Step 4: USAGE.md:242** + +Delete exactly this sentence and the space before it: ` \`cc x web\` sur un projet en \`dev\` garde les connecteurs higgsfield refusés (union); \`set web\` dans le projet les rend.` The line keeps `… reste sans effet. \`cc\` est une fonction de \`lib/cc.sh\`…`. + +- [ ] **Step 5: CHANGELOG.md [Unreleased]** + +Delete line 62 (`- Known limit: \`cc x web\` on a project in \`dev\` keeps the higgsfield connectors denied …`). + +In line 63 replace ` (the stderr line "blocked by enterprise policy: claude.ai higgsfield, claude.ai Higgsfield AI" appeared on the deny profiles dev, qa, seo and minimal: that is \`deniedMcpServers\` working)` with nothing (the sentence continues with `; qa = …`). + +Append at the end of `### Changed` (after the `skillOverrides` bullet, before the blank line and `### Removed`): + +```markdown +- Profiles deny no claude.ai connector: the two higgsfield connectors were removed from the claude.ai account on 2026-11-09, so `deniedMcpServers` leaves `audit`, `dev`, `minimal`, `qa` and `seo`, and the pack census drops its connector rule. A project that ran `profile.sh set` with one of those five profiles before this change keeps the two entries in its `.claude/settings.local.json`, and no profile verb strips them any more: harmless while the connectors stay removed, delete them by hand before reconnecting either one. Reconnecting them for good: revert the `chore(profiles)` commit of this change, which restores the denies and their census rule. +``` + +- [ ] **Step 6: Run the check and the suites** + +Run the Step 1 command: expected no output. Then `grep -c '—' <(git diff develop -- lib/profiles/README.md skills/profile/SKILL.md USAGE.md CHANGELOG.md | grep '^+' | grep -v '^+++')` → `0`. Then `bash lib/profile.sh list` (9 lines). Then `GATES_TIMEOUT=600 PATH="$HOME/.bun/bin:$PATH" make test` → `all suites green`. + +- [ ] **Step 7: Commit** + +```bash +git add lib/profiles/README.md skills/profile/SKILL.md USAGE.md CHANGELOG.md +git commit -m "docs(profiles): profiles no longer described by connector state" +``` diff --git a/CHANGELOG.md b/CHANGELOG.md index 7ea9958..29a33d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -59,11 +59,11 @@ Format follows [Keep a Changelog](https://keepachangelog.com/) and this project - `settings.json` sets `"autoMemoryEnabled": false`. `make doctor` gains an Auto memory section (the setting, plus leftover files under `~/.claude/projects/*/memory/`) and checks the `~/.claude/rules` symlink (8 links). The session-start health check includes `rules`. - `lib/tests/doctrine-citers.test.sh`: the file-citation census also reads nested `lib//` paths, `~/.claude/` and `$HOME/.claude/` prefixes (mapped to this repo) and `templates/project-rules/`; a bare `.claude/rules/` citation resolves by citer (this repo's own rules from `.claude/rules/` or `rules/`, else `templates/project-rules/`); T6 also scans `templates/` and `.claude/rules/`, T3 keeps its roots. - `link.sh` no longer links the design and scroll skills flat; impeccable moves to `skills-external/impeccable`. Docs and routing (`CLAUDE.global.md`, `/profile`, README, USAGE, ARCHITECTURE) speak packs. -- Known limit: `cc x web` on a project in `dev` keeps the higgsfield connectors denied (`deniedMcpServers` is a union); `profile.sh set web` in the project lifts them from the next session. -- Measured headless on 2026-11-02: dev = `pack-gstack-dev`, 41 tools, 0 higgsfield; web = the six web packs, 199 tools, both connectors `connected` and 158 higgsfield tools listed in init (the stderr line "blocked by enterprise policy: claude.ai higgsfield, claude.ai Higgsfield AI" appeared on the deny profiles dev, qa, seo and minimal: that is `deniedMcpServers` working); qa = `pack-gstack-browser pack-web-validate`; seo = qa + `pack-gstack-dev pack-seo`; qa and seo 41 tools, 0 higgsfield; reload canary in one flagless session (id `ee65507c-a958-411b-9580-8aca8105e326`): `/seo` unavailable on minimal, `profile.sh enable seo`, `/reload-plugins` -> "Reloaded: 3 plugins · 2 skills · 32 agents · 7 hooks", then `/seo` and `/pack-seo:seo` both load the SEO skill. `profile.sh current --plain` median 30 ms (target 50). +- Measured headless on 2026-11-02: dev = `pack-gstack-dev`, 41 tools, 0 higgsfield (dev, qa and seo denied the connectors at the time); web = the six web packs, 199 tools, both connectors `connected` and 158 higgsfield tools listed in init; qa = `pack-gstack-browser pack-web-validate`; seo = qa + `pack-gstack-dev pack-seo`; qa and seo 41 tools, 0 higgsfield; reload canary in one flagless session (id `ee65507c-a958-411b-9580-8aca8105e326`): `/seo` unavailable on minimal, `profile.sh enable seo`, `/reload-plugins` -> "Reloaded: 3 plugins · 2 skills · 32 agents · 7 hooks", then `/seo` and `/pack-seo:seo` both load the SEO skill. `profile.sh current --plain` median 30 ms (target 50). - Listing budget with the packs: measured headless on 2026-11-02 with `--model haiku` (name-only skills, entries 124 on full, 90 on dev): full default 58, 40000 11, 50000 0, 60000 0; dev default 9, 40000 and above 0. Set `SLASH_COMMAND_TOOL_CHAR_BUDGET=50000` in `settings.json` `env`, the smallest tested value with 0 name-only on full. Cost, estimated: full (48.5k - 30.3k bytes) / 4, about 4.5k tokens; dev 30.0k to 36.8k bytes, about 1.7k tokens. `env` is global, so every profile pays. Descriptions are no longer truncated at 50000 (natural size 48.5k). The default budget's absolute value was not read; it may depend on the model's context window. - gitflow pre-commit (`lib/gitflow.sh`, generated `githooks/pre-commit` and per-repo `.githooks/pre-commit`) exempts on `main`/`develop` only staged paths under `.claude/memory/`, `.claude/tasks/`, `.claude/audits/`, `.claude/deploy/` and `.githooks/`, was all of `.claude/**`. A commit touching `.claude/rules/`, `.claude/settings.json`, agents or skills on a protected base is now blocked: branch first. Staged paths are listed with `--no-renames`, so a `git mv` from a blocked path into the allowlist is blocked too. Per-repo hooks pick it up at the next session start, the global ones at `make link`. Tests: `lib/gitflow-test.sh` T21d-T21h. - `settings.json` gains `skillOverrides` setting the claude.ai-synced skills to `"off"`, global so a plain `claude` gets it too. Listed by name: a skill synced later stays listed until its name is added, and a same-named skill elsewhere is hidden too. A project re-enables one with `{"skillOverrides": {"": "on"}}` in its `.claude/settings.local.json`. The reason is listing cost: every synced skill is listed in every session's context. Measured headless on the full profile on 2026-11-09, CLI 2.1.319: Skills 16.2k to 12.5k, total 32.2k to 28.5k. The listing budget is unchanged (40000 and 50000 give the same listing once the synced skills are off). `syncClaudeAiSkills: false` is not used: it moves the synced skills to `~/.claude/skills/.trash/`. Check `claude --version` on another machine before pulling. +- Profiles deny no claude.ai connector: the two higgsfield connectors were removed from the claude.ai account on 2026-11-09, so `deniedMcpServers` leaves `audit`, `dev`, `minimal`, `qa` and `seo`, and the pack census drops its connector rule. A project that ran `profile.sh set` with one of those five profiles before this change keeps the two entries in its `.claude/settings.local.json`, and no profile verb strips them any more: harmless while the connectors stay removed, delete them by hand before reconnecting either one. Reconnecting them for good: revert the merge of `chore/connector-deny-cleanup` into develop (`git revert -m 1 `), which restores the denies, their census rule and the docs. ### Removed - `rules/default-language.md`: its content is `lib/architecture-defaults.md` § Default language. diff --git a/USAGE.md b/USAGE.md index 7cd0473..dff8a95 100644 --- a/USAGE.md +++ b/USAGE.md @@ -239,7 +239,7 @@ Hotfix/quick fix → tout OFF (skills superpowers vendorisés, toujours **GSD v2** n'est pas un plugin Claude Code — c'est un CLI externe. Il ne consomme pas de tokens passifs. Tu le lances dans un terminal séparé avec `gsd`, puis `/gsd auto` pour le mode autonome. -**Profils et packs.** Un profil se règle par projet (`/profile set web` puis `/reload-plugins`) ou par conversation (`cc web`, la conversation est figée: relance-la pour changer). Neuf profils: `full`, `max`, `minimal`, `dev`, `design`, `web`, `seo`, `qa`, `audit`. Sans profil, c'est `full`. Un `--settings` édité en cours de session reste sans effet. `cc x web` sur un projet en `dev` garde les connecteurs higgsfield refusés (union); `set web` dans le projet les rend. `cc` est une fonction de `lib/cc.sh`, à sourcer depuis `~/.bashrc` (`[ -f "$HOME/.claude/lib/cc.sh" ] && . "$HOME/.claude/lib/cc.sh"`) ; `make doctor` le signale tant qu'elle manque. +**Profils et packs.** Un profil se règle par projet (`/profile set web` puis `/reload-plugins`) ou par conversation (`cc web`, la conversation est figée: relance-la pour changer). Neuf profils: `full`, `max`, `minimal`, `dev`, `design`, `web`, `seo`, `qa`, `audit`. Sans profil, c'est `full`. Un `--settings` édité en cours de session reste sans effet. `cc` est une fonction de `lib/cc.sh`, à sourcer depuis `~/.bashrc` (`[ -f "$HOME/.claude/lib/cc.sh" ] && . "$HOME/.claude/lib/cc.sh"`) ; `make doctor` le signale tant qu'elle manque. --- diff --git a/lib/pack-census-fragments.jq b/lib/pack-census-fragments.jq index 163d95b..d079b1d 100644 --- a/lib/pack-census-fragments.jq +++ b/lib/pack-census-fragments.jq @@ -1,13 +1,11 @@ # lib/pack-census-fragments.jq — fragment invariants (lib/pack-census.sh). -# $m = manifests [{id,on}], $deny = space-separated profiles that deny the -# two higgsfield connectors; inputs = lib/profiles/*.json. Prints RED lines, +# $m = manifests [{id,on}]; inputs = lib/profiles/*.json. Prints RED lines, # and WARN lines for a pack id with no manifest. def name_of: input_filename | sub(".*/"; ""); def dn: [(.deniedMcpServers // [])[] | .serverName] | sort; [inputs | {f: name_of, frag: .}] as $all | ($all[] | select(.f == "full.json") | .frag) as $full | ($full.enabledPlugins | keys) as $keys -| ($deny | split(" ") | map(. + ".json")) as $deny_files | ($m | map({key: .id, value: .on}) | from_entries) as $mdef | ($m | map(.id)) as $mids | ( [$all[] | {f, ep: .frag.enabledPlugins, d: (.frag | dn)}] as $s @@ -25,12 +23,6 @@ def dn: [(.deniedMcpServers // [])[] | .serverName] | sort; ( ["example-skills@anthropic-agent-skills", "brightdata-plugin@synced"][] | select($g.enabledPlugins[.] != false) | "RED lib/profiles/\($f): \(.) must be false" ), - ( (["claude.ai higgsfield", "claude.ai Higgsfield AI"] | sort) as $both - | if (($deny_files | index($f)) != null) and (($g | dn) != $both) - then "RED lib/profiles/\($f): must deny both higgsfield connectors" - elif (($deny_files | index($f)) == null) and (($g | dn) | length) > 0 - then "RED lib/profiles/\($f): must deny no connector" - else empty end ), ( if $f == "full.json" then ($mdef | to_entries[] | select($g.enabledPlugins[.key] != .value) | "RED lib/profiles/full.json: \(.key) is \($g.enabledPlugins[.key])" diff --git a/lib/pack-census.sh b/lib/pack-census.sh index 82cae4b..ec3df47 100755 --- a/lib/pack-census.sh +++ b/lib/pack-census.sh @@ -11,8 +11,7 @@ # flat and in a pack; no retired gstack name (lib/gstack-removed.list). # 2. fragments lib/profiles/*.json: same key set as full.json; model-router # + security-guidance true, example-skills + brightdata false -# everywhere; the two higgsfield connectors denied on exactly -# DENY_PROFILES; full.json packs = manifest defaults. +# everywhere; full.json packs = manifest defaults. # 3. no reader of the old layout left (scope and terms in check_citers). # Shared by make test (lib/tests/pack-census.test.sh) and doctor.sh. # Prints RED/WARN lines, then `PACKS OK

packs skills` when no RED. @@ -35,7 +34,6 @@ PROFILES="$REPO/lib/profiles" REMOVED="$REPO/lib/gstack-removed.list" HERE="$(cd -P "$(dirname "${BASH_SOURCE[0]}")" && pwd)" FRAG_JQ="$HERE/pack-census-fragments.jq" -DENY_PROFILES="audit dev minimal qa seo" # spec § 2 red=0; packs=0; skills=0 declare -A seen red() { echo "RED $*"; red=1; } @@ -75,7 +73,7 @@ check_entry() { # $1 pack dir, $2 entry path check_fragments() { local files=("$PROFILES"/*.json) full="$PROFILES/full.json" out [ -f "$full" ] || { red "lib/profiles/full.json missing"; return; } - out="$(jq -rn --arg deny "$DENY_PROFILES" --argjson m "$(manifests_json)" \ + out="$(jq -rn --argjson m "$(manifests_json)" \ -f "$FRAG_JQ" "${files[@]}")" \ || { red "lib/profiles: a fragment is not JSON"; return; } [ -z "$out" ] || echo "$out" diff --git a/lib/profiles/README.md b/lib/profiles/README.md index 62d69b4..34fd1dd 100644 --- a/lib/profiles/README.md +++ b/lib/profiles/README.md @@ -2,23 +2,21 @@ A profile is a literal Claude Code settings fragment: `enabledPlugins` (every pack `pack-@skills-dir` and managed plugin, explicit), optional -`deniedMcpServers` (the two higgsfield claude.ai connectors), optional +`deniedMcpServers` (claude.ai connectors to deny), optional `model`. Per project: `bash ~/.claude/lib/profile.sh set ` writes it into `.claude/settings.local.json`, then `/reload-plugins`. Per conversation: `cc ` (lib/cc.sh) runs `claude --settings lib/profiles/.json`; that conversation is frozen (no reload brings a pack back; relaunch instead). No profile = the manifest -defaults = `full` with the connectors present. `deniedMcpServers` is a union -across files: a `cc x web` over a project set to `dev` keeps the connectors -denied; `set web` in the project brings them back next session. +defaults = `full`. `profile.sh list` reads these lines (format `- **name**: text`): -- **full**: every pack except higgsfield and extras; ui-ux-pro-max on; connectors present. The default. +- **full**: every pack except higgsfield and extras; ui-ux-pro-max on. The default. - **max**: everything on, pr-review-toolkit included; for a one-off session, not a project. -- **minimal**: no pack, no design plugin, connectors denied; the smallest listing. +- **minimal**: no pack, no design plugin; the smallest listing. - **dev**: gstack-dev only; backend or tooling work without UI. -- **design**: design, scroll3d, gstack-design, gstack-browser, ui-ux-pro-max; connectors present. +- **design**: design, scroll3d, gstack-design, gstack-browser, ui-ux-pro-max; UI and visual design work. - **web**: design + scroll3d + web-validate + the three gstack packs + ui-ux-pro-max; public site work. - **seo**: seo, web-validate, gstack-browser, gstack-dev; audit and fixes on a live site. - **qa**: gstack-browser + web-validate; dogfooding and conformance only. @@ -27,6 +25,6 @@ denied; `set web` in the project brings them back next session. Invariants (checked by `lib/pack-census.sh`): the same key set in every fragment; `model-router@skills-dir` and `security-guidance@claude-code-plugins` true everywhere; `example-skills@anthropic-agent-skills` and -`brightdata-plugin@synced` false everywhere; the connectors denied on exactly -minimal, dev, seo, qa, audit; `full` equal to the manifest defaults. +`brightdata-plugin@synced` false everywhere; `full` equal to the manifest +defaults. Add your own profile as another `.json` with the same key set. diff --git a/lib/profiles/audit.json b/lib/profiles/audit.json index 30ccb0f..57bc508 100644 --- a/lib/profiles/audit.json +++ b/lib/profiles/audit.json @@ -15,13 +15,5 @@ "pr-review-toolkit@claude-code-plugins": true, "example-skills@anthropic-agent-skills": false, "brightdata-plugin@synced": false - }, - "deniedMcpServers": [ - { - "serverName": "claude.ai higgsfield" - }, - { - "serverName": "claude.ai Higgsfield AI" - } - ] + } } diff --git a/lib/profiles/dev.json b/lib/profiles/dev.json index 829bef0..a927e03 100644 --- a/lib/profiles/dev.json +++ b/lib/profiles/dev.json @@ -15,13 +15,5 @@ "pr-review-toolkit@claude-code-plugins": false, "example-skills@anthropic-agent-skills": false, "brightdata-plugin@synced": false - }, - "deniedMcpServers": [ - { - "serverName": "claude.ai higgsfield" - }, - { - "serverName": "claude.ai Higgsfield AI" - } - ] + } } diff --git a/lib/profiles/minimal.json b/lib/profiles/minimal.json index d98652a..a182983 100644 --- a/lib/profiles/minimal.json +++ b/lib/profiles/minimal.json @@ -15,13 +15,5 @@ "pr-review-toolkit@claude-code-plugins": false, "example-skills@anthropic-agent-skills": false, "brightdata-plugin@synced": false - }, - "deniedMcpServers": [ - { - "serverName": "claude.ai higgsfield" - }, - { - "serverName": "claude.ai Higgsfield AI" - } - ] + } } diff --git a/lib/profiles/qa.json b/lib/profiles/qa.json index c8c7319..2231e4d 100644 --- a/lib/profiles/qa.json +++ b/lib/profiles/qa.json @@ -15,13 +15,5 @@ "pr-review-toolkit@claude-code-plugins": false, "example-skills@anthropic-agent-skills": false, "brightdata-plugin@synced": false - }, - "deniedMcpServers": [ - { - "serverName": "claude.ai higgsfield" - }, - { - "serverName": "claude.ai Higgsfield AI" - } - ] + } } diff --git a/lib/profiles/seo.json b/lib/profiles/seo.json index 0b93d92..5119843 100644 --- a/lib/profiles/seo.json +++ b/lib/profiles/seo.json @@ -15,13 +15,5 @@ "pr-review-toolkit@claude-code-plugins": false, "example-skills@anthropic-agent-skills": false, "brightdata-plugin@synced": false - }, - "deniedMcpServers": [ - { - "serverName": "claude.ai higgsfield" - }, - { - "serverName": "claude.ai Higgsfield AI" - } - ] + } } diff --git a/lib/tests/pack-census.test.sh b/lib/tests/pack-census.test.sh index 32b6c35..27e3c49 100755 --- a/lib/tests/pack-census.test.sh +++ b/lib/tests/pack-census.test.sh @@ -1,7 +1,7 @@ #!/usr/bin/env bash # lib/tests/pack-census.test.sh — lib/pack-census.sh: pack layout (manifest # name = folder, entries resolve, no skill twice, retired gstack names absent), -# fragment invariants (same key set, fixed values, deny set, full = manifest +# fragment invariants (same key set, fixed values, full = manifest # defaults), old-layout citers. Fixture cases, then the hermetic part of the # census on the real repo (dangling targets are WARN without --installed). set -u @@ -26,11 +26,10 @@ mk_pack() { # name defaultEnabled skill... } mk_pack alpha true a1 a2 mk_pack beta false b1 -frag() { # name alpha beta deny(yes|no) — the two real connector names - local d=""; [ "$4" = yes ] && d=', "deniedMcpServers": [{"serverName": "claude.ai higgsfield"}, {"serverName": "claude.ai Higgsfield AI"}]' - printf '{"enabledPlugins": {"model-router@skills-dir": true, "pack-alpha@skills-dir": %s, "pack-beta@skills-dir": %s, "security-guidance@claude-code-plugins": true, "example-skills@anthropic-agent-skills": false, "brightdata-plugin@synced": false}%s}\n' \ - "$2" "$3" "$d" > "$FX/lib/profiles/$1.json"; } -frag full true false no; frag dev false false yes +frag() { # name alpha beta + printf '{"enabledPlugins": {"model-router@skills-dir": true, "pack-alpha@skills-dir": %s, "pack-beta@skills-dir": %s, "security-guidance@claude-code-plugins": true, "example-skills@anthropic-agent-skills": false, "brightdata-plugin@synced": false}}\n' \ + "$2" "$3" > "$FX/lib/profiles/$1.json"; } +frag full true false; frag dev false false census() { bash "$ROOT/lib/pack-census.sh" --repo "$FX" "$@" 2>&1; } out="$(census)"; rc=$? @@ -86,10 +85,10 @@ printf '{"enabledPlugins": {"model-router@skills-dir": true, "pack-alpha@skills- out="$(census)"; rc=$? check T8-keyset-rc "$rc" 1; check_has T8-keyset "$out" "RED lib/profiles/short.json: key set differs from full.json" rm "$FX/lib/profiles/short.json" -frag full true true no +frag full true true out="$(census)"; rc=$? check T9-full-defaults-rc "$rc" 1; check_has T9-full-defaults "$out" "RED lib/profiles/full.json: pack-beta@skills-dir is true but the manifest default is false" -frag full true false no +frag full true false sed -i.bak 's/"security-guidance@claude-code-plugins": true/"security-guidance@claude-code-plugins": false/' "$FX/lib/profiles/dev.json" out="$(census)"; rc=$? check T10-fixed-rc "$rc" 1; check_has T10-fixed "$out" "RED lib/profiles/dev.json: security-guidance@claude-code-plugins must be true" @@ -101,6 +100,10 @@ out="$(census)"; rc=$? check T13-same-rc "$rc" 1 check_has T13-same "$out" "RED lib/profiles/dev.json and zdev.json are identical fragments" rm "$FX/lib/profiles/zdev.json" +jq '. + {deniedMcpServers: [{serverName: "claude.ai Fictional"}]}' "$FX/lib/profiles/dev.json" > "$FX/lib/profiles/zdev.json" +out="$(census)" +check T13-deny-differs "$(grep -c 'zdev.json are identical fragments' <<<"$out")" 0 +rm "$FX/lib/profiles/zdev.json" sed 's/pack-beta@skills-dir": false/pack-beta@skills-dir": false, "pack-ghost@skills-dir": false/' "$FX/lib/profiles/dev.json" > "$FX/lib/profiles/ghost.json" out="$(census)"; rc=$? check_has T14-ghost "$out" "WARN lib/profiles/ghost.json: names pack-ghost with no skills/pack-ghost/" diff --git a/skills/profile/SKILL.md b/skills/profile/SKILL.md index 06c98f7..7c2c40a 100644 --- a/skills/profile/SKILL.md +++ b/skills/profile/SKILL.md @@ -23,8 +23,8 @@ output. With no argument, run `current` and then `list`. ## What a profile is `lib/profiles/.json` holds `enabledPlugins` (every pack and managed -plugin, explicit), optional `deniedMcpServers` (the two higgsfield claude.ai -connectors) and optional `model`. Descriptions: `lib/profiles/README.md`. +plugin, explicit), optional `deniedMcpServers` (claude.ai connectors to +deny) and optional `model`. Descriptions: `lib/profiles/README.md`. - Per project: `set ` merges the fragment into `.claude/settings.local.json` (other keys kept). Then `/reload-plugins` @@ -34,8 +34,7 @@ connectors) and optional `model`. Descriptions: `lib/profiles/README.md`. `claude --settings lib/profiles/.json`. That conversation is frozen: editing the fragment or the local file changes nothing here, and a pack the fragment turns off cannot come back; start another `cc`. -- No profile: the manifest defaults, which equal `full` with the connectors - present. +- No profile: the manifest defaults, which equal `full`. ## Verbs @@ -58,9 +57,6 @@ root (no `CLAUDE.md`, no `.git`), unreadable or invalid local JSON. plugins through the `claude plugin` CLI. A pack need found mid-skill is proposed to the user (`set ` or `enable ` + `/reload-plugins`, or a relaunch under `--settings`), written only on consent (lib/plugin-gate.md). -- `deniedMcpServers` is a union across settings files: a `cc x web` over a - project set to `dev` keeps the connectors denied; `set web` in the - project brings them back for the next session. - `max` turns on `pack-extras` (diagram, make-pdf, 21st-ai, 21st-ui-explore, 21st-ui-review); `pack-higgsfield` is on in `max` only, else `enable higgsfield` for a named media ask.