chore(memory): BDR-137 + LRN-258..261 + BLK-041 + EVAL-057 — ship-feature phase 4b memory capture
This commit is contained in:
1 parent
181bcfc7f2
commit
08e36dcc0b
5 files changed
+44
No files matched your search
@@ -440,3 +440,10 @@ Dogfood: 3 blind lenses attacked the v1 plan for the plan-challenge feature itse
|
||||
- **Result**: plan r1 FATAL(8)+FATAL(5): bench script broken (pipe ate stdin), quoted finish form escaped the gate — both caught before any code. SDD 11 tasks, 1 fix round (Task 3). Final review: 3 Important (macOS T13, symlink whole-file report, guard undocumented) → fix wave. Verifier 1: ECARTS(6), 3 human-gated criteria written from the plan/spec rather than the contract; verifier 2: ECARTS(2) (post-merge user step, USAGE scope). Security PASS, 1 MEDIUM (`rtk read -n .env`).
|
||||
- **Anomalies**: criterion 11 encoded a hypothesis (M3q ASKED) as an oracle before the bench measured it → abandoned; contract criteria 1/5/7 drifted from gated plan/spec decisions (r3 deviations not mirrored into the contract) → 3 human round-trips at the end.
|
||||
- **Action**: write a measured oracle only after the measurement; when a plan revision deviates from a contract criterion, amend the criterion `[gated]` at the plan gate, not at GATE 1.
|
||||
|
||||
## EVAL-057 — 4b run: task reviews caught 5 Important, final opus review 2 more + 13 minors, fix rounds regressed twice, one controller ruling wrong [keep] (2026-11-04)
|
||||
- **Checked**: 4b /ship-feature run quality on an 8-task mod branch (`feature/memory-capture`).
|
||||
- **Method**: defects counted per stage: plan challenge, per-task sonnet reviews + scoped re-reviews, final opus review, verifier ×2 + re-judge, security gate ×3.
|
||||
- **Result**: plan r1 FATAL(9) (note unprovable in `-p`) before code. Task reviews caught 5 Important (quadratic STATUS regex, heredoc commit form never matched, unguarded `fs.exists`, whole-command milestone regexes, fs.exists missing/unreadable). Final opus review still found 2 Important + 13 minors (all-placeholder grams on real registries, redaction gaps, `> \d+` letterless, success path reading the store per call). Security gate PASS ×3 but each coverage round found new shapes (cookie tail from the fix itself, `-b`, JSON affixes). Fix rounds introduced 2 regressions (quadratic JWT, cookie 400-cap), both caught by scoped re-reviews.
|
||||
- **Anomalies**: controller ruling "letterless rule subsumed by ERRORISH" was wrong (`> \d+` alternative) and cost one revert; "1:1 port" claim in noise.py drifted as the TS rule grew; the verifier's second pass refused `gates.sh run` (it rewrites the contract) and re-ran the CHECKs read-only instead.
|
||||
- **Action**: a ruling that removes a check lists the counterexample search over the alternatives first; reviewers measure regex cost by running; keep a scoped re-review after every fix round, a round of its own can regress; a port of a live rule carries the commit it was ported from.
|
||||
Reference in new issue
Block a user